Skip to content

Commit 23f09b2

Browse files
committed
PI-2517 - update integration tests
1 parent c0a9eb4 commit 23f09b2

10 files changed

+2
-15
lines changed

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/IntegrationTestBase.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ abstract class IntegrationTestBase {
2727
final val basePath = "/v1/persons"
2828
final val pnc = URLEncoder.encode("2004/13116M", StandardCharsets.UTF_8)
2929
final val nomsId = "G2996UX"
30-
final val crn = "ABC123"
30+
final val crn = "ABC123"
3131

3232
companion object {
3333
private val hmppsAuthMockServer = HmppsAuthMockServer()

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/CaseNotesIntegrationTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class CaseNotesIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns case notes for a person`() {
1211
callApi("$basePath/$crn/case-notes")

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/LicenceConditionIntegrationTest.kt

-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class LicenceConditionIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns alerts for a person`() {
1211
callApi("$basePath/$crn/licences/conditions")
1312
.andExpect(status().isOk)
1413
.andExpect(content().json(getExpectedResponse("person-licence-conditions")))
1514
}
16-
1715
}

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/NeedsIntegrationTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class NeedsIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns needs for a person`() {
1211
callApi("$basePath/$pnc/needs")

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/OffencesIntegrationTest.kt

-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class OffencesIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns offences for a person`() {
1211
callApi("$basePath/$pnc/offences")
1312
.andExpect(status().isOk)
1413
.andExpect(content().json(getExpectedResponse("person-offences")))
1514
}
16-
1715
}

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/PersonResponsibleOfficerIntegrationTest.kt

-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class PersonResponsibleOfficerIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns needs for a person`() {
1211
callApi("$basePath/$pnc/person-responsible-officer")
1312
.andExpect(status().isOk)
1413
.andExpect(content().json(getExpectedResponse("person-responsible-officer")))
1514
}
16-
1715
}

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/ProtectedCharacteristicsIntegrationTest.kt

-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class ProtectedCharacteristicsIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns protected characteristics for a person`() {
1211
callApi("$basePath/$pnc/protected-characteristics")
1312
.andExpect(status().isOk)
1413
.andExpect(content().json(getExpectedResponse("person-protected-characteristics")))
1514
}
16-
1715
}

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/RiskManagementIntegrationTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

88
class RiskManagementIntegrationTest : IntegrationTestBase() {
9-
109
@Test
1110
fun `returns protected characteristics for a person`() {
1211
callApi("$basePath/$crn/risk-management-plan")

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/RisksIntegrationTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
77
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
88

99
class RisksIntegrationTest : IntegrationTestBase() {
10-
1110
@ParameterizedTest
1211
@ValueSource(strings = ["scores", "categories", "mappadetail", "dynamic", "serious-harm"])
1312
fun `returns protected characteristics for a person`(path: String) {

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/SentencesIntegrationTest.kt

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ import org.springframework.test.web.servlet.result.MockMvcResultMatchers.content
55
import org.springframework.test.web.servlet.result.MockMvcResultMatchers.status
66
import uk.gov.justice.digital.hmpps.hmppsintegrationapi.integration.IntegrationTestBase
77

8-
class SentencesIntegrationTest : IntegrationTestBase() {
9-
8+
class SentencesIntegrationTest : IntegrationTestBase() {
109
final var path = "$basePath/$pnc/sentences"
1110

1211
@Test

0 commit comments

Comments
 (0)