convention edits to enum

Author: gbmojo

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/HmppsMessage.kt

@@ -2,7 +2,7 @@ package uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps
 
 data class HmppsMessage(
   val messageId: String,
-  val eventType: String,
+  val eventType: HmppsMessageEventType,
   val description: String? = null,
   val messageAttributes: Map<String, String> = emptyMap(),
 )

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/HmppsMessageEventType.kt

@@ -1,5 +1,13 @@
 package uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps
 
-enum class HmppsMessageEventType {
-  ExpressionOfInterestCreated,
+enum class HmppsMessageEventType(
+  val type: String,
+  val eventTypeCoe: String,
+  val description: String,
+) {
+  EXPRESSION_OF_INTEREST_CREATED(
+    type = "mjma-jobs-board.job.created",
+    eventTypeCoe = "ExpressionOfInterestCreated",
+    description = "An expression of interest has been created",
+  ),
 }

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestService.kt

@@ -27,7 +27,7 @@ class PutExpressionInterestService(
         objectMapper.writeValueAsString(
           HmppsMessage(
             messageId = UUID.randomUUID().toString(),
-            eventType = HmppsMessageEventType.ExpressionOfInterestCreated.name,
+            eventType = HmppsMessageEventType.EXPRESSION_OF_INTEREST_CREATED,
             messageAttributes =
               mapOf(
                 "jobId" to expressionOfInterest.jobId,

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestServiceTest.kt

@@ -79,7 +79,7 @@ class PutExpressionInterestServiceTest :
         val expectedMessage =
           HmppsMessage(
             messageId = "1",
-            eventType = HmppsMessageEventType.ExpressionOfInterestCreated.name,
+            eventType = HmppsMessageEventType.EXPRESSION_OF_INTEREST_CREATED,
             messageAttributes =
               mapOf(
                 "jobId" to "12345",
@@ -95,7 +95,7 @@ class PutExpressionInterestServiceTest :
         assert(deserializedMap.containsKey("messageAttributes"))
         assert(deserializedMap.containsKey("eventType"))
         assertEquals(
-          expected = "ExpressionOfInterestCreated",
+          expected = "EXPRESSION_OF_INTEREST_CREATED",
           actual = eventType,
         )
 
@@ -109,7 +109,7 @@ class PutExpressionInterestServiceTest :
         val expectedMessage =
           HmppsMessage(
             messageId = "1",
-            eventType = HmppsMessageEventType.ExpressionOfInterestCreated.name,
+            eventType = HmppsMessageEventType.EXPRESSION_OF_INTEREST_CREATED,
             messageAttributes =
               mapOf(
                 "jobId" to "12345",
@@ -122,7 +122,7 @@ class PutExpressionInterestServiceTest :
         val eventType = deserializedMap["eventType"]
 
         assertEquals(
-          expected = "ExpressionOfInterestCreated",
+          expected = "EXPRESSION_OF_INTEREST_CREATED",
           actual = eventType,
         )
 
@@ -138,34 +138,5 @@ class PutExpressionInterestServiceTest :
           },
         )
       }
-
-      it("allows messages of any type and anybody to be sent") {
-        val externalType = "externalType"
-
-        val expectedMessage =
-          HmppsMessage(
-            messageId = "1",
-            eventType = externalType,
-            messageAttributes =
-              mapOf(
-                "personId" to "12345",
-                "entityNumber" to "H1234",
-              ),
-          )
-
-        val serializedJson = objectMapper.writeValueAsString(expectedMessage)
-
-        val deserializedMap: Map<String, Any?> = objectMapper.readValue(serializedJson)
-        val eventType = deserializedMap["eventType"]
-
-        assertEquals(
-          expected = externalType,
-          actual = eventType,
-        )
-
-        val messageAttributes = deserializedMap["messageAttributes"] as? Map<String, String>
-        messageAttributes?.containsKey("personId")?.let { assert(it) }
-        messageAttributes?.containsKey("entityNumber")?.let { assert(it) }
-      }
     }
   })