Added tests.

Author: stevomcallister

src/main/resources/application-integration-test.yml

@@ -68,6 +68,7 @@ authorisation:
       - "/v1/persons/.*/cell-location"
       - "/v1/epf/person-details/.*/[^/]*$"
       - "/v1/hmpps/id/nomis-number/[^/]*$"
+      - "/v1/hmpps/id/.*/nomis-number"
       - "/health"
       - "/health/ping"
       - "/health/readiness"

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/HmppsIdIntegrationTest.kt

@@ -17,4 +17,56 @@ class HmppsIdIntegrationTest : IntegrationTestBase() {
         ),
       )
   }
+
+  @Test
+  fun `gets the nomis Id for a HMPPSID where the id is a crn`() {
+    callApi("/v1/hmpps/id/$crn/nomis-number")
+      .andExpect(status().isOk)
+      .andExpect(
+        content().json(
+          """
+        {"data":{"nomisNumber":"G5555TT"}}
+      """,
+        ),
+      )
+  }
+
+  @Test
+  fun `gets the nomis Id for a HMPPSID where the id is a NOMIS id`() {
+    callApi("/v1/hmpps/id/$nomsId/nomis-number")
+      .andExpect(status().isOk)
+      .andExpect(
+        content().json(
+          """
+        {"data":{"nomisNumber":"G2996UX"}}
+      """,
+        ),
+      )
+  }
+
+  @Test
+  fun `gets the nomis Id for a HMPPSID where the id is invalid`() {
+    callApi("/v1/hmpps/id/invalidId/nomis-number")
+      .andExpect(status().is4xxClientError)
+      .andExpect(
+        content().json(
+          """
+        {"userMessage":"Invalid HMPPS ID: invalidId","developerMessage":"Validation failure: Invalid HMPPS ID: invalidId"}
+      """,
+        ),
+      )
+  }
+
+  @Test
+  fun `gets the nomis Id for a HMPPSID where the id not found`() {
+    callApi("/v1/hmpps/id/invalidId/nomis-number")
+      .andExpect(status().is4xxClientError)
+      .andExpect(
+        content().json(
+          """
+        {"userMessage":"Invalid HMPPS ID: invalidId","developerMessage":"Validation failure: Invalid HMPPS ID: invalidId","moreInfo":null}
+      """,
+        ),
+      )
+  }
 }

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/IntegrationTestBase.kt

@@ -27,7 +27,7 @@ abstract class IntegrationTestBase {
   final val basePath = "/v1/persons"
   final val pnc = URLEncoder.encode("2004/13116M", StandardCharsets.UTF_8)
   final val nomsId = "G2996UX"
-  final val crn = "ABC123"
+  final val crn = "AB123123"
 
   companion object {
     private val hmppsAuthMockServer = HmppsAuthMockServer()