additonal risk category integration tests and endpoint schema update

Author: wcdkj

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/RiskCategoriesController.kt

@@ -35,6 +35,7 @@ class RiskCategoriesController(
     responses = [
       ApiResponse(responseCode = "200", useReturnTypeSchema = true, description = "Successfully found risk categories for a person with the provided HMPPS ID."),
       ApiResponse(responseCode = "404", content = [Content(schema = Schema(ref = "#/components/schemas/PersonNotFound"))]),
+      ApiResponse(responseCode = "400", content = [Content(schema = Schema(ref = "#/components/schemas/BadRequest"))]),
       ApiResponse(responseCode = "500", content = [Content(schema = Schema(ref = "#/components/schemas/InternalServerError"))]),
     ],
   )

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/RisksIntegrationTest.kt

@@ -14,4 +14,25 @@ class RisksIntegrationTest : IntegrationTestBase() {
       .andExpect(status().isOk)
       .andExpect(content().json(getExpectedResponse("person-risk-$path")))
   }
+
+  @ParameterizedTest
+  @ValueSource(strings = ["categories"])
+  fun `return a 404 when prison not in filter`(path: String) {
+    callApiWithCN("$basePath/$crn/risks/$path", limitedPrisonsCn)
+      .andExpect(status().isNotFound)
+  }
+
+  @ParameterizedTest
+  @ValueSource(strings = ["categories"])
+  fun `returns a 404 for prisoner in wrong prison`(path: String) {
+    callApiWithCN("$basePath/$crn/risks/$path", noPrisonsCn)
+      .andExpect(status().isNotFound)
+  }
+
+  @ParameterizedTest
+  @ValueSource(strings = ["categories"])
+  fun `return a 400 when invalid hmpps submitted`(path: String) {
+    callApi("$basePath/invalid=invalid/risks/$path")
+      .andExpect(status().isBadRequest)
+  }
 }