Change Person conditonal ID (#367)

popey2700 · web-flow · commit 5eabddb81dde · 2024-02-06T13:07:43.000Z
* Change Person conditional ID
diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetPersonsService.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetPersonsService.kt
@@ -19,7 +19,7 @@ class GetPersonsService(
     val personsFromProbationOffenderSearch = probationOffenderSearchGateway.getPersons(firstName, lastName, pncNumber, dateOfBirth, searchWithinAliases)
 
     if (!pncNumber.isNullOrEmpty()) {
-      hmppsId = personsFromProbationOffenderSearch.data.firstOrNull()?.identifiers?.deliusCrn
+      hmppsId = personsFromProbationOffenderSearch.data.firstOrNull()?.identifiers?.nomisNumber
     }
 
     val responseFromPrisonerOffenderSearch = prisonerOffenderSearchGateway.getPersons(firstName, lastName, hmppsId, dateOfBirth, searchWithinAliases)
diff --git a/src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetPersonsServiceTest.kt b/src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetPersonsServiceTest.kt
@@ -68,7 +68,7 @@ internal class GetPersonsServiceTest(
   }
 
   it("allows prisonerOffenderSearchGateway to search with a hmppsId if a pncNumber is passed in") {
-    val responseFromProbationOffenderSearch = Response(data = listOf(Person(firstName, lastName, middleName = "John", identifiers = Identifiers(deliusCrn = "A1234AA"))))
+    val responseFromProbationOffenderSearch = Response(data = listOf(Person(firstName, lastName, middleName = "John", identifiers = Identifiers(nomisNumber = "A1234AA"))))
 
     whenever(probationOffenderSearchGateway.getPersons(firstName, lastName, pncNumber, dateOfBirth)).thenReturn(responseFromProbationOffenderSearch)
     whenever(prisonerOffenderSearchGateway.getPersons(firstName, lastName, hmppsId, dateOfBirth)).thenReturn(Response(data = emptyList()))

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class GetPersonsService(`
`19`	`19`	`val personsFromProbationOffenderSearch = probationOffenderSearchGateway.getPersons(firstName, lastName, pncNumber, dateOfBirth, searchWithinAliases)`
`20`	`20`
`21`	`21`	`if (!pncNumber.isNullOrEmpty()) {`
`22`		`- hmppsId = personsFromProbationOffenderSearch.data.firstOrNull()?.identifiers?.deliusCrn`
	`22`	`+ hmppsId = personsFromProbationOffenderSearch.data.firstOrNull()?.identifiers?.nomisNumber`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`val responseFromPrisonerOffenderSearch = prisonerOffenderSearchGateway.getPersons(firstName, lastName, hmppsId, dateOfBirth, searchWithinAliases)`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ internal class GetPersonsServiceTest(`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`it("allows prisonerOffenderSearchGateway to search with a hmppsId if a pncNumber is passed in") {`
`71`		`- val responseFromProbationOffenderSearch = Response(data = listOf(Person(firstName, lastName, middleName = "John", identifiers = Identifiers(deliusCrn = "A1234AA"))))`
	`71`	`+ val responseFromProbationOffenderSearch = Response(data = listOf(Person(firstName, lastName, middleName = "John", identifiers = Identifiers(nomisNumber = "A1234AA"))))`
`72`	`72`
`73`	`73`	`whenever(probationOffenderSearchGateway.getPersons(firstName, lastName, pncNumber, dateOfBirth)).thenReturn(responseFromProbationOffenderSearch)`
`74`	`74`	`whenever(prisonerOffenderSearchGateway.getPersons(firstName, lastName, hmppsId, dateOfBirth)).thenReturn(Response(data = emptyList()))`