Skip to content

Commit b211d33

Browse files
AlexHerbertMadeTechAlexHerbertMadeTech
committed
[HIA-721]
WIP Fix for unit test
1 parent d3e5d95 commit b211d33

File tree

1 file changed

+69
-73
lines changed

1 file changed

+69
-73
lines changed

‎src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetRiskManagementPlansForCrnServiceTest.kt

+69-73
Original file line numberDiff line numberDiff line change
@@ -26,86 +26,82 @@ class GetRiskManagementPlansForCrnServiceTest(
2626

2727
val crn = "D1974X"
2828
val badCrn = "Not a real CRN"
29-
30-
beforeEach {
31-
val testPlan =
32-
CrnRiskManagementPlans(
33-
crn = crn,
34-
limitedAccessOffender = "true",
35-
riskManagementPlan =
36-
listOf(
37-
CrnRiskManagementPlan(
38-
assessmentId = "123450",
39-
dateCompleted = "2024-05-04T01 =04 =20",
40-
partcompStatus = "string",
41-
initiationDate = "2024-05-04T01 =04 =20",
42-
assessmentStatus = "string",
43-
assessmentType = "string",
44-
superStatus = "string",
45-
keyInformationCurrentSituation = "string",
46-
furtherConsiderationsCurrentSituation = "string",
47-
supervision = "string",
48-
monitoringAndControl = "string",
49-
interventionsAndTreatment = "string",
50-
victimSafetyPlanning = "string",
51-
contingencyPlans = "string",
52-
laterWIPAssessmentExists = "true",
53-
latestWIPDate = "2024-05-04T01 =04 =20",
54-
laterSignLockAssessmentExists = "true",
55-
latestSignLockDate = "2024-05-04T01 =04 =20",
56-
laterPartCompUnsignedAssessmentExists = "true",
57-
latestPartCompUnsignedDate = "2024-05-04T01 =04 =20",
58-
laterPartCompSignedAssessmentExists = "true",
59-
latestPartCompSignedDate = "2024-05-04T01 =04 =20",
60-
laterCompleteAssessmentExists = "true",
61-
latestCompleteDate = "2024-05-04T01 =04 =20",
62-
),
63-
CrnRiskManagementPlan(
64-
assessmentId = "123451",
65-
dateCompleted = "2024-05-04T01 =04 =20",
66-
partcompStatus = "string",
67-
initiationDate = "2024-05-04T01 =04 =20",
68-
assessmentStatus = "string",
69-
assessmentType = "string",
70-
superStatus = "string",
71-
keyInformationCurrentSituation = "string",
72-
furtherConsiderationsCurrentSituation = "string",
73-
supervision = "string",
74-
monitoringAndControl = "string",
75-
interventionsAndTreatment = "string",
76-
victimSafetyPlanning = "string",
77-
contingencyPlans = "string",
78-
laterWIPAssessmentExists = "true",
79-
latestWIPDate = "2024-05-04T01 =04 =20",
80-
laterSignLockAssessmentExists = "true",
81-
latestSignLockDate = "2024-05-04T01 =04 =20",
82-
laterPartCompUnsignedAssessmentExists = "true",
83-
latestPartCompUnsignedDate = "2024-05-04T01 =04 =20",
84-
laterPartCompSignedAssessmentExists = "true",
85-
latestPartCompSignedDate = "2024-05-04T01 =04 =20",
86-
laterCompleteAssessmentExists = "true",
87-
latestCompleteDate = "2024-05-04T01 =04 =20",
88-
),
29+
val testPlan =
30+
CrnRiskManagementPlans(
31+
crn = crn,
32+
limitedAccessOffender = "true",
33+
riskManagementPlan =
34+
listOf(
35+
CrnRiskManagementPlan(
36+
assessmentId = "123450",
37+
dateCompleted = "2024-05-04T01 =04 =20",
38+
partcompStatus = "string",
39+
initiationDate = "2024-05-04T01 =04 =20",
40+
assessmentStatus = "string",
41+
assessmentType = "string",
42+
superStatus = "string",
43+
keyInformationCurrentSituation = "string",
44+
furtherConsiderationsCurrentSituation = "string",
45+
supervision = "string",
46+
monitoringAndControl = "string",
47+
interventionsAndTreatment = "string",
48+
victimSafetyPlanning = "string",
49+
contingencyPlans = "string",
50+
laterWIPAssessmentExists = "true",
51+
latestWIPDate = "2024-05-04T01 =04 =20",
52+
laterSignLockAssessmentExists = "true",
53+
latestSignLockDate = "2024-05-04T01 =04 =20",
54+
laterPartCompUnsignedAssessmentExists = "true",
55+
latestPartCompUnsignedDate = "2024-05-04T01 =04 =20",
56+
laterPartCompSignedAssessmentExists = "true",
57+
latestPartCompSignedDate = "2024-05-04T01 =04 =20",
58+
laterCompleteAssessmentExists = "true",
59+
latestCompleteDate = "2024-05-04T01 =04 =20",
8960
),
90-
)
61+
CrnRiskManagementPlan(
62+
assessmentId = "123451",
63+
dateCompleted = "2024-05-04T01 =04 =20",
64+
partcompStatus = "string",
65+
initiationDate = "2024-05-04T01 =04 =20",
66+
assessmentStatus = "string",
67+
assessmentType = "string",
68+
superStatus = "string",
69+
keyInformationCurrentSituation = "string",
70+
furtherConsiderationsCurrentSituation = "string",
71+
supervision = "string",
72+
monitoringAndControl = "string",
73+
interventionsAndTreatment = "string",
74+
victimSafetyPlanning = "string",
75+
contingencyPlans = "string",
76+
laterWIPAssessmentExists = "true",
77+
latestWIPDate = "2024-05-04T01 =04 =20",
78+
laterSignLockAssessmentExists = "true",
79+
latestSignLockDate = "2024-05-04T01 =04 =20",
80+
laterPartCompUnsignedAssessmentExists = "true",
81+
latestPartCompUnsignedDate = "2024-05-04T01 =04 =20",
82+
laterPartCompSignedAssessmentExists = "true",
83+
latestPartCompSignedDate = "2024-05-04T01 =04 =20",
84+
laterCompleteAssessmentExists = "true",
85+
latestCompleteDate = "2024-05-04T01 =04 =20",
86+
),
87+
),
88+
)
89+
val testErrors = listOf(
90+
UpstreamApiError(
91+
causedBy = UpstreamApi.RISK_MANAGEMENT_PLAN,
92+
type = UpstreamApiError.Type.ENTITY_NOT_FOUND,
93+
description = "Lorem Ipsum dolor sit amet",
94+
)
95+
)
9196

97+
beforeEach {
9298
Mockito.reset(riskManagementGateway)
9399

94100
whenever(riskManagementGateway.getRiskManagementPlansForCrn(crn)).thenReturn(
95101
Response(data = testPlan, errors = emptyList()),
96102
)
97103
whenever(riskManagementGateway.getRiskManagementPlansForCrn(badCrn)).thenReturn(
98-
Response(
99-
data = null,
100-
errors =
101-
listOf(
102-
UpstreamApiError(
103-
causedBy = UpstreamApi.RISK_MANAGEMENT_PLAN,
104-
type = UpstreamApiError.Type.ENTITY_NOT_FOUND,
105-
description = "Lorem Ipsum dolor sit amet",
106-
),
107-
),
108-
),
104+
Response(data = null, errors = testErrors),
109105
)
110106
}
111107

@@ -120,7 +116,7 @@ class GetRiskManagementPlansForCrnServiceTest(
120116
it("Returns error without valid CRN") {
121117
val result = serviceUnderTest.execute(badCrn)
122118
verify(riskManagementGateway, VerificationModeFactory.times(1)).getRiskManagementPlansForCrn(badCrn)
123-
assert(result.data?.size == 0)
119+
result.data?.isEmpty()?.let { assert(it) }
124120
assert(result.errors.isNotEmpty())
125121
}
126122
}

0 commit comments

Comments
 (0)