WIP - api current returns empty array, fixing

Author: chiaramapellimt

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/CaseNoteController.kt src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/CaseNotesController.kt

@@ -10,13 +10,13 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.extensions.decodeUrlChar
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.PageCaseNote
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApi
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApiError
-import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetCaseNoteForPersonService
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetCaseNotesForPersonService
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.internal.AuditService
 
 @RestController
 @RequestMapping("/v1/persons")
-class CaseNoteController(
-  @Autowired val getCaseNoteForPersonService: GetCaseNoteForPersonService,
+class CaseNotesController(
+  @Autowired val getCaseNoteForPersonService: GetCaseNotesForPersonService,
   @Autowired val auditService: AuditService,
 ) {
   @GetMapping("{encodedHmppsId}/case-notes")

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetCaseNoteForPersonService.kt src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetCaseNotesForPersonService.kt

@@ -7,7 +7,7 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.PageCaseNot
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
 
 @Service
-class GetCaseNoteForPersonService(
+class GetCaseNotesForPersonService(
   @Autowired val caseNotesGateway: CaseNotesGateway,
   @Autowired val getPersonService: GetPersonService,
 ) {

src/main/resources/application-dev.yml

@@ -39,6 +39,7 @@ authorisation:
       - "/v1/persons/.*/risks"
       - "/v1/persons/.*/adjudications"
       - "/v1/persons/.*/licences/conditions"
+      - "/v1/persons/.*/case-notes"
     ctrlo:
       - "/v1/epf/person-details/.*/.*"
     kubernetes-health-check-client:

src/main/resources/application-local-docker.yml

@@ -36,6 +36,7 @@ authorisation:
       - "/v1/persons/.*/needs"
       - "/v1/persons/.*/risks"
       - "/v1/persons/.*/reported-adjudications"
+      - "/v1/persons/.*/case-notes"
       - "/v1/epf/person-details/.*/.*"
       - "/health"
       - "/health/ping"

src/main/resources/application-local.yml

@@ -42,6 +42,7 @@ authorisation:
       - "/v1/persons/.*/needs"
       - "/v1/persons/.*/risks"
       - "/v1/persons/.*/reported-adjudications"
+      - "/v1/persons/.*/case-notes"
       - "/v1/epf/person-details/.*/.*"
       - "/health"
       - "/health/ping"

src/main/resources/application-test.yml

@@ -54,6 +54,7 @@ authorisation:
       - "/v1/epf/person-details/.*/.*"
       - "/v1/persons/.*/adjudications"
       - "/v1/persons/.*/licences/conditions"
+      - "/v1/persons/.*/case-notes"
       - "/health"
       - "/health/ping"
       - "/health/readiness"

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/CaseNoteControllerTest.kt src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/CaseNotesControllerTest.kt

@@ -18,16 +18,16 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.helpers.IntegrationAPIMo
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.CaseNote
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.PageCaseNote
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
-import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetCaseNoteForPersonService
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetCaseNotesForPersonService
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.internal.AuditService
 import java.net.URLEncoder
 import java.nio.charset.StandardCharsets
 
-@WebMvcTest(controllers = [CaseNoteController::class])
+@WebMvcTest(controllers = [CaseNotesController::class])
 @ActiveProfiles("test")
-class CaseNoteControllerTest(
+class CaseNotesControllerTest(
   @Autowired var springMockMvc: MockMvc,
-  @MockBean val getCaseNoteForPersonService: GetCaseNoteForPersonService,
+  @MockBean val getCaseNotesForPersonService: GetCaseNotesForPersonService,
   @MockBean val auditService: AuditService,
 ) : DescribeSpec(
   {
@@ -43,9 +43,9 @@ class CaseNoteControllerTest(
       )
     describe("GET $path") {
       beforeTest {
-        Mockito.reset(getCaseNoteForPersonService)
+        Mockito.reset(getCaseNotesForPersonService)
         Mockito.reset(auditService)
-        whenever(getCaseNoteForPersonService.execute(hmppsId)).thenReturn(
+        whenever(getCaseNotesForPersonService.execute(hmppsId)).thenReturn(
           Response(
             data = pageCaseNote,
             errors = emptyList(),
@@ -62,7 +62,7 @@ class CaseNoteControllerTest(
       it("gets the case notes for a person with the matching ID") {
         mockMvc.performAuthorised(path)
 
-        verify(getCaseNoteForPersonService, VerificationModeFactory.times(1)).execute(hmppsId)
+        verify(getCaseNotesForPersonService, VerificationModeFactory.times(1)).execute(hmppsId)
       }
 
       it("returns the case notes for a person with the matching ID") {

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetCaseNoteForPersonServiceTest.kt src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetCaseNotesForPersonServiceTest.kt

@@ -18,12 +18,12 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
 
 @ContextConfiguration(
   initializers = [ConfigDataApplicationContextInitializer::class],
-  classes = [GetCaseNoteForPersonService::class],
+  classes = [GetCaseNotesForPersonService::class],
 )
-class GetCaseNoteForPersonServiceTest(
+class GetCaseNotesForPersonServiceTest(
   @MockBean val caseNotesGateway: CaseNotesGateway,
   @MockBean val getPersonService: GetPersonService,
-  private val getCaseNoteForPersonService: GetCaseNoteForPersonService,
+  private val getCaseNoteForPersonService: GetCaseNotesForPersonService,
 ) : DescribeSpec(
   {
     val hmppsId = "1234/56789B"

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/smoke/person/CaseNotesSmokeTest.kt

@@ -0,0 +1,39 @@
+package uk.gov.justice.digital.hmpps.hmppsintegrationapi.smoke.person
+
+import io.kotest.assertions.json.shouldEqualJson
+import io.kotest.core.spec.style.DescribeSpec
+import io.kotest.matchers.shouldBe
+import org.springframework.http.HttpStatus
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.extensions.removeWhitespaceAndNewlines
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.helpers.IntegrationAPIHttpClient
+import java.net.URLEncoder
+import java.nio.charset.StandardCharsets
+
+class CaseNotesSmokeTest : DescribeSpec(
+  {
+    val hmppsId = "ABC123"
+    val encodedHmppsId = URLEncoder.encode(hmppsId, StandardCharsets.UTF_8)
+    val basePath = "v1/persons/$encodedHmppsId/case-notes"
+    val httpClient = IntegrationAPIHttpClient()
+
+    it("returns case notes for a person") {
+      val response = httpClient.performAuthorised(basePath)
+      response.statusCode().shouldBe(HttpStatus.OK.value())
+      response.body().shouldEqualJson(
+        """
+         {
+          "data":
+            {
+              "caseNotes": [
+                {
+                  "caseNoteId": "12311312"
+                }
+              ]
+            }
+         }
+
+        """.removeWhitespaceAndNewlines(),
+      )
+    }
+  },
+)