Added service function

Author: chiaramapellimt

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/AlertsController.kt

@@ -44,7 +44,7 @@ class AlertsController(
     @RequestParam(required = false, defaultValue = "10", name = "perPage") perPage: Int,
   ): PaginatedResponse<Alert> {
     val hmppsId = encodedHmppsId.decodeUrlCharacters()
-    val response = getAlertsForPersonService.execute(hmppsId)
+    val response = getAlertsForPersonService.getAlertsForPnd(hmppsId)
 
     if (response.hasError(UpstreamApiError.Type.ENTITY_NOT_FOUND)) {
       throw EntityNotFoundException("Could not find person with id: $hmppsId")

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetAlertsForPersonService.kt

@@ -25,4 +25,29 @@ class GetAlertsForPersonService(
       errors = nomisAlerts.errors + personResponse.errors,
     )
   }
+
+  fun getAlertsForPnd(hmppsId: String): Response<List<Alert>> {
+    val personResponse = getPersonService.execute(hmppsId = hmppsId)
+    val nomisNumber = personResponse.data?.identifiers?.nomisNumber
+    var nomisAlerts: Response<List<Alert>> = Response(data = emptyList())
+
+    if (nomisNumber != null) {
+      val allNomisAlerts = nomisGateway.getAlertsForPerson(nomisNumber)
+      val filteredAlerts =
+        allNomisAlerts.data?.filter {
+          it.code in
+            listOf(
+              "BECTER", "HA", "XA", "XCA", "XEL", "XELH", "XER", "XHT", "XILLENT",
+              "XIS", "XR", "XRF", "XSA", "HA2", "RCS", "RDV", "RKC", "RPB", "RPC",
+              "RSS", "RST", "RDP", "REG", "RLG", "ROP", "RRV", "RTP", "RYP", "HS", "SC",
+            )
+        }.orEmpty()
+      nomisAlerts = Response(data = filteredAlerts, errors = allNomisAlerts.errors)
+    }
+
+    return Response(
+      data = nomisAlerts.data,
+      errors = nomisAlerts.errors + personResponse.errors,
+    )
+  }
 }

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/AlertsControllerTest.kt

@@ -193,7 +193,7 @@ internal class AlertsControllerTest(
         beforeTest {
           Mockito.reset(getAlertsForPersonService)
           Mockito.reset(auditService)
-          whenever(getAlertsForPersonService.execute(hmppsId)).thenReturn(
+          whenever(getAlertsForPersonService.getAlertsForPnd(hmppsId)).thenReturn(
             Response(
               data =
                 listOf(
@@ -220,7 +220,7 @@ internal class AlertsControllerTest(
         }
 
         it("returns paginated results for PND") {
-          whenever(getAlertsForPersonService.execute(hmppsId)).thenReturn(
+          whenever(getAlertsForPersonService.getAlertsForPnd(hmppsId)).thenReturn(
             Response(
               data =
                 List(20) {
@@ -252,7 +252,7 @@ internal class AlertsControllerTest(
             URLEncoder.encode(hmppsIdForPersonWithNoAlerts, StandardCharsets.UTF_8)
           val alertPath = "/v1/persons/$encodedHmppsIdForPersonWithNoAlerts/alerts/pnd"
 
-          whenever(getAlertsForPersonService.execute(hmppsIdForPersonWithNoAlerts)).thenReturn(
+          whenever(getAlertsForPersonService.getAlertsForPnd(hmppsIdForPersonWithNoAlerts)).thenReturn(
             Response(
               data = emptyList(),
             ),
@@ -275,7 +275,7 @@ internal class AlertsControllerTest(
         it("gets the alerts for PND for a person with the matching ID") {
           mockMvc.performAuthorised(pndPath)
 
-          verify(getAlertsForPersonService, VerificationModeFactory.times(1)).execute(hmppsId)
+          verify(getAlertsForPersonService, VerificationModeFactory.times(1)).getAlertsForPnd(hmppsId)
         }
       }
     },

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetAlertsForPersonServiceTest.kt

@@ -2,6 +2,7 @@ package uk.gov.justice.digital.hmpps.hmppsintegrationapi.services
 
 import io.kotest.core.spec.style.DescribeSpec
 import io.kotest.matchers.collections.shouldHaveSize
+import io.kotest.matchers.shouldBe
 import org.mockito.Mockito
 import org.mockito.internal.verification.VerificationModeFactory
 import org.mockito.kotlin.verify
@@ -30,7 +31,8 @@ internal class GetAlertsForPersonServiceTest(
       val hmppsId = "1234/56789B"
       val prisonerNumber = "Z99999ZZ"
       val deliusCrn = "X777776"
-      val alert = Alert()
+      val alert = Alert(code = "XA", codeDescription = "Test Alert XA")
+      val nonMatchingAlert = Alert(code = "INVALID", codeDescription = "Invalid Alert")
 
       val person =
         Person(firstName = "Qui-gon", lastName = "Jin", identifiers = Identifiers(nomisNumber = prisonerNumber, deliusCrn = deliusCrn))
@@ -47,6 +49,7 @@ internal class GetAlertsForPersonServiceTest(
             data =
               listOf(
                 alert,
+                nonMatchingAlert,
               ),
           ),
         )
@@ -108,5 +111,31 @@ internal class GetAlertsForPersonServiceTest(
         val response = getAlertsForPersonService.execute(hmppsId)
         response.errors.shouldHaveSize(1)
       }
+
+      it("records errors when it cannot find PND alerts for a person") {
+        whenever(nomisGateway.getAlertsForPerson(id = prisonerNumber)).thenReturn(
+          Response(
+            data = emptyList(),
+            errors =
+              listOf(
+                UpstreamApiError(
+                  causedBy = UpstreamApi.NOMIS,
+                  type = UpstreamApiError.Type.ENTITY_NOT_FOUND,
+                ),
+              ),
+          ),
+        )
+
+        val response = getAlertsForPersonService.getAlertsForPnd(hmppsId)
+        response.errors.shouldHaveSize(1)
+      }
+
+      it("returns PND filtered data") {
+        val response = getAlertsForPersonService.getAlertsForPnd(hmppsId)
+
+        response.data.shouldHaveSize(1)
+        response.data[0].code shouldBe "XA"
+        response.data[0].codeDescription shouldBe "Test Alert XA"
+      }
     },
   )