Added test to check for errors when code not in list

Author: chiaramapellimt

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/UpstreamApiError.kt

@@ -3,7 +3,6 @@ package uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps
 data class UpstreamApiError(val causedBy: UpstreamApi, val type: Type, val description: String? = null) {
   enum class Type {
     ENTITY_NOT_FOUND,
-    ATTRIBUTE_NOT_FOUND,
     BAD_REQUEST,
     FORBIDDEN,
     INTERNAL_SERVER_ERROR,

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetAlertsForPersonService.kt

@@ -5,6 +5,8 @@ import org.springframework.stereotype.Service
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.gateways.NomisGateway
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Alert
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApi
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApiError
 
 @Service
 class GetAlertsForPersonService(
@@ -42,6 +44,18 @@ class GetAlertsForPersonService(
               "RSS", "RST", "RDP", "REG", "RLG", "ROP", "RRV", "RTP", "RYP", "HS", "SC",
             )
         }.orEmpty()
+      if (filteredAlerts.isEmpty()) {
+        return Response(
+          data = emptyList(),
+          errors =
+            listOf(
+              UpstreamApiError(
+                causedBy = UpstreamApi.PRISONER_OFFENDER_SEARCH,
+                type = UpstreamApiError.Type.ENTITY_NOT_FOUND,
+              ),
+            ),
+        )
+      }
       nomisAlerts = Response(data = filteredAlerts, errors = allNomisAlerts.errors)
     }
 

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetAlertsForPersonServiceTest.kt

@@ -137,5 +137,20 @@ internal class GetAlertsForPersonServiceTest(
         response.data[0].code shouldBe "XA"
         response.data[0].codeDescription shouldBe "Test Alert XA"
       }
+
+      it("returns an error when the alert code is not in the allowed list") {
+        whenever(personService.execute(hmppsId = deliusCrn)).thenReturn(Response(person))
+        whenever(personService.execute(hmppsId = hmppsId)).thenReturn(Response(person))
+        whenever(nomisGateway.getAlertsForPerson(prisonerNumber)).thenReturn(
+          Response(
+            data = listOf(nonMatchingAlert),
+          ),
+        )
+
+        val response = getAlertsForPersonService.getAlertsForPnd(hmppsId)
+
+        response.errors.shouldHaveSize(1)
+        response.data.shouldHaveSize(0)
+      }
     },
   )