Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIA-390] Contact Details #359

Merged
merged 22 commits into from
Feb 6, 2024
Merged

[HIA-390] Contact Details #359

merged 22 commits into from
Feb 6, 2024

Conversation

AlexHerbertMoJ
Copy link
Contributor

Adding contact details to Person endpoint

AlexHerbertMadeTech and others added 9 commits January 26, 2024 11:53
@AlexHerbertMadeTech
[HIA-390]
ab67929 
Adding some new properties to model and linking them in to base Person
@AlexHerbertMadeTech
[HIA-390]
a59fc1f 
Adding some new properties to model and linking them in to base Person
@AlexHerbertMadeTech
[HIA-390]
d67bd44 
Allowing new contact detail objects to be nullable
Adding data to the test case to ensure Person object is correctly created containing contact details
@AlexHerbertMadeTech
[HIA-390]
4b91261 
Making changes to smoke tests to ensure contact details come through as expected
@AlexHerbertMadeTech
[HIA-390]
8c099eb 
Merging main to prevent conflicts
Ensuring everything is LF instead of CRLF
@AlexHerbertMadeTech
sh: line 1: wq: command not found
7bdd96a 
This reverts commit 4b91261.
@AlexHerbertMadeTech
[HIA-390]
6ab67b9 
Merging main to prevent conflicts
Ensuring everything is LF instead of CRLF
@AlexHerbertMadeTech
Merge remote-tracking branch 'origin/HIA-390' into HIA-390
09c6dcc
@AlexHerbertMadeTech
[HIA-390]
7291b04 
Trying to revert a commit to fix my git inconsistencies
@AlexHerbertMadeTech
reverting gradle windows script file
8639962
@AlexHerbertMadeTech
[HIA-390]
4841bf9 
Trying to revert a commit to fix my git inconsistencies
@AlexHerbertMadeTech
[HIA-390]
b8e68e7 
Trying to revert a commit to fix my git inconsistencies
@AlexHerbertMadeTech
[HIA-390]
1a5c481 
Trying to revert a commit to fix my git inconsistencies
@AlexHerbertMadeTech
[HIA-390]
5143f50 
Formatting from ktlint
@AlexHerbertMadeTech
[HIA-390]
668e43c 
Removing wildcard import as per ktlint
@AlexHerbertMadeTech
[HIA-390]
dbed583 
formatting changes as per ktlint
@AlexHerbertMadeTech
[HIA-390]
4c0c645 
adding missing imports
@AlexHerbertMadeTech
[HIA-390]
9178d7f 
Fixing smoke test
@AlexHerbertMadeTech
[HIA-390]
9754aa6 
Fixing smoke test
@AlexHerbertMadeTech
[HIA-390]
2238114 
Fixing last accidental change
@AlexHerbertMadeTech
[HIA-390]
6f328be 
Merging main for completeness
@AlexHerbertMadeTech
[HIA-390]
9abe41a 
Removing unnecessary test
popey2700
popey2700 reviewed Feb 6, 2024
View reviewed changes
.trivyignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this...?

popey2700
popey2700 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@popey2700 popey2700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice inherit with the contact classes

@AlexHerbertMoJ AlexHerbertMoJ merged commit 474f1e8 into main Feb 6, 2024
5 checks passed
@AlexHerbertMoJ AlexHerbertMoJ deleted the HIA-390 branch February 6, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popey2700 popey2700 popey2700 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexHerbertMoJ @popey2700 @AlexHerbertMadeTech