Hia 623-B person search by pnc fix #367
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when a PNC search is carried out we start with probation and get a response where we then extract an ID and use this extracted ID to query PrisonerOffenderSearch. This ID was previously CRN however it makes more sense for this to be a NomisNumber. This is all because we cant directly query PrisonerOffenderSearch with PNC
chiaramapellimt
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently when a PNC search is carried out we start with probation and get a response where we then extract an ID and use this extracted ID to query PrisonerOffenderSearch. This ID was previously CRN however it makes more sense for this to be a NomisNumber. This is all because we cant directly query PrisonerOffenderSearch with PNC.
Changes proposed in this PR