Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MappaDetail domain to use Number instead of Integer and update… #388

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

CslBing
Copy link

@CslBing CslBing commented Mar 19, 2024

… openapi documentation

openapi.yml Outdated
@@ -431,11 +431,11 @@ paths:
type: object
properties:
level:
type: string
type: integer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason they're Integer here and Number below?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason, as it would be the same either way. Updated to use number instead

Copy link
Contributor

@AlexHerbertMoJ AlexHerbertMoJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CslBing CslBing merged commit 60a3974 into main Mar 19, 2024
5 checks passed
@CslBing CslBing deleted the HIA-668-Risk-MAPPA-level-golden-record branch March 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants