Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hia 745 bug v 1 persons hmpps id response is returning addresses in contact details when it shouldnt #428

Merged
merged 4 commits into from
May 21, 2024
Merged

Hia 745 bug v 1 persons hmpps id response is returning addresses in contact details when it shouldnt #428

merged 4 commits into from
May 21, 2024

Conversation

popey2700
Copy link
Contributor

Context

  • When our users hit /v1/persons/{hmppsId} they receive Person data which contains contact details. This ContactDetails should only contain EmailAndPhone but appears mistakenly to contain unMapped probation addresses. Additionally probation emails are also being mapped incorrectly

Changes proposed in this PR

  • Update ContactDetails model and Addresses model

@popey2700 popey2700 merged commit 6bc0cb1 into main May 21, 2024
5 checks passed
@popey2700 popey2700 deleted the HIA-745-bug-v-1-persons-hmpps-id-response-is-returning-addresses-in-contact-details-when-it-shouldnt branch May 21, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiaramapellimt chiaramapellimt chiaramapellimt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popey2700 @chiaramapellimt