Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hia 759 fix latest key dates and adjustments pnd queries #451

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Hia 759 fix latest key dates and adjustments pnd queries #451

merged 4 commits into from
Jun 28, 2024

Conversation

popey2700
Copy link
Contributor

@popey2700 popey2700 commented Jun 27, 2024 •
edited
Loading

Context

  • PND recently raised a query regarding latest-key-dates-and-adjustments and some of the data which makes up the response. We discovered our openApi spec was not accurately describing the data that could return from the endpoint

Changes proposed in this PR

  • Updated OpenApi spec
  • Don't return key value pairs in SentenceKeyDates if null

@popey2700 popey2700 merged commit f9c068c into main Jun 28, 2024
5 checks passed
@popey2700 popey2700 deleted the HIA-759-fix-latest-key-dates-and-adjustments-pnd-queries branch June 28, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CslBing CslBing CslBing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popey2700 @CslBing