PES - add hmpps id endpoint for a given nomis number #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CslBing
reviewed
Jul 4, 2024
| @@ -33,7 +33,7 @@ data class Offender( | |||
| deliusCrn = otherIds.crn, | |||
| ), | |||
| pncId = otherIds.pncNumber, | |||
| hmppsId = otherIds.crn, | |||
| hmppsId = if (otherIds.crn?.isNotEmpty() == true) otherIds.crn else otherIds.nomsNumber, | |||
There was a problem hiding this comment.
Would we want to return nonsNumber as hmppsId? Also would probation search return person without CRN? Perharps you are looking to update POSPrisoner(person search from Prisoner serach) to return hmppsId?
mxco86
force-pushed
the
PES-add-hmpps-id-endpoint-for-noms-number
branch
from
e597b13 to
02fb606
Compare
mxco86
force-pushed
the
PES-add-hmpps-id-endpoint-for-noms-number
branch
from
17caade to
b546920
Compare
mxco86
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint to retrieve HMPPS ID given a nomis number. Until the HMPPS core person work is finialised this endpoint will return the crn in most cases but could also return the nomis number where no crn exists for a person.