Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsonInclude SentenceKeyDate #453

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Update jsonInclude SentenceKeyDate #453

merged 3 commits into from
Jul 4, 2024

Conversation

popey2700
Copy link
Contributor

Context

  • We recently changed the SentenceKeyDate model to exclude properties if they're null however this is inconsistent with the rest of the API's handling of null values and as a result we need to rectify this issue.

Changes proposed in this PR

  • Created a new SentenceKeyDatesWithCalculatedDate model
  • Removed ignore if null annotation

@popey2700 popey2700 merged commit b73e6ea into main Jul 4, 2024
5 checks passed
@popey2700 popey2700 deleted the fix-bug-in-sentences-key-dates-and-adjustments branch July 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CslBing CslBing CslBing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popey2700 @CslBing