Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated regex to handle one letter prefix X123123 #515

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

stevomcallister
Copy link
Contributor

@stevomcallister stevomcallister commented Nov 13, 2024

apparently CRN can be X123123 and XX123123 so updated to cope with both

@stevomcallister stevomcallister changed the title updated regex to handle one letter suffix X123123 updated regex to handle one letter prefix X123123 Nov 13, 2024
Copy link
Contributor

@marcus-bcl marcus-bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! I thought Delius only supported a single letter - no idea where the 2-letter variation came from.

@stevomcallister
Copy link
Contributor Author

Weird! I thought Delius only supported a single letter - no idea where the 2-letter variation came from.

it may just be the test data... all the crns in the tests are CCNNNNNN

@stevomcallister stevomcallister merged commit dbe6897 into main Nov 13, 2024
15 checks passed
@stevomcallister stevomcallister deleted the RR-1068-CRN-regex branch November 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants