From ce0869450b066d9cc89b3195f416017861d09e4e Mon Sep 17 00:00:00 2001 From: stevomcallister Date: Thu, 21 Nov 2024 10:05:15 +0000 Subject: [PATCH 1/2] added logging to diagnose issue --- .../gateways/PrisonerOffenderSearchGateway.kt | 6 ++++++ .../hmppsintegrationapi/services/GetHmppsIdService.kt | 7 ++++++- src/main/resources/application-dev.yml | 5 +++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PrisonerOffenderSearchGateway.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PrisonerOffenderSearchGateway.kt index 03ecd431d..3f83442c5 100644 --- a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PrisonerOffenderSearchGateway.kt +++ b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PrisonerOffenderSearchGateway.kt @@ -1,5 +1,6 @@ package uk.gov.justice.digital.hmpps.hmppsintegrationapi.gateways +import org.slf4j.LoggerFactory import org.springframework.beans.factory.annotation.Autowired import org.springframework.beans.factory.annotation.Value import org.springframework.http.HttpMethod @@ -18,6 +19,8 @@ class PrisonerOffenderSearchGateway( ) { private val webClient = WebClientWrapper(baseUrl) + private val log: org.slf4j.Logger = LoggerFactory.getLogger(this::class.java) + @Autowired lateinit var hmppsAuthGateway: HmppsAuthGateway @@ -56,6 +59,7 @@ class PrisonerOffenderSearchGateway( } fun getPrisonOffender(nomsNumber: String): Response { + log.info("looking up the person via prison search $nomsNumber") val result = webClient.request( HttpMethod.GET, @@ -66,10 +70,12 @@ class PrisonerOffenderSearchGateway( return when (result) { is WebClientWrapperResponse.Success -> { + log.info("found a match via prison search $nomsNumber") Response(data = result.data) } is WebClientWrapperResponse.Error -> { + log.error("An error occurred getting person from prion search: ${result.errors}") Response( data = null, errors = result.errors, diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt index 9f719c2ad..ffa9250d3 100644 --- a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt +++ b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt @@ -1,5 +1,6 @@ package uk.gov.justice.digital.hmpps.hmppsintegrationapi.services +import org.slf4j.LoggerFactory import org.springframework.beans.factory.annotation.Autowired import org.springframework.stereotype.Service import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.HmppsId @@ -10,14 +11,18 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response class GetHmppsIdService( @Autowired val getPersonService: GetPersonService, ) { + + private val log: org.slf4j.Logger = LoggerFactory.getLogger(this::class.java) + fun execute(hmppsId: String): Response { val personResponse = getPersonService.execute(hmppsId.uppercase()) var hmppsIdToReturn = personResponse.data?.hmppsId - + log.info("hmppsId from probation: $hmppsIdToReturn") if (hmppsIdToReturn == null) { hmppsIdToReturn = getPersonService.getPersonFromNomis(hmppsId.uppercase()).data?.prisonerNumber + log.info("hmppsId from prison: $hmppsIdToReturn") } return Response( diff --git a/src/main/resources/application-dev.yml b/src/main/resources/application-dev.yml index ad0529211..11897f133 100644 --- a/src/main/resources/application-dev.yml +++ b/src/main/resources/application-dev.yml @@ -114,3 +114,8 @@ authorisation: - "/v1/persons/.*/plp/inductionScheduleUpdated" - "/v1/hmpps/id/by-nomis-number/[^/]*$" - "/v1/hmpps/id/nomis-number/by-hmpps-id/[^/]*$" + +logging: + level: + root: INFO + uk.gov.justice.digital.hmpps.hmppsintegrationapi: DEBUG From 39a4209ca80b015145c11f0914e49a4fb4013c4d Mon Sep 17 00:00:00 2001 From: stevomcallister Date: Thu, 21 Nov 2024 10:08:06 +0000 Subject: [PATCH 2/2] added logging to diagnose issue --- .../hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt index ffa9250d3..36d180f0d 100644 --- a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt +++ b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/GetHmppsIdService.kt @@ -11,7 +11,6 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response class GetHmppsIdService( @Autowired val getPersonService: GetPersonService, ) { - private val log: org.slf4j.Logger = LoggerFactory.getLogger(this::class.java) fun execute(hmppsId: String): Response {