Added induction schedule history #556
Conversation
| @@ -32,7 +33,7 @@ class PLPController( | |||
| ) { | |||
| @GetMapping("{hmppsId}/plp-induction-schedule") | |||
| @Operation( | |||
| summary = "Returns plp the induction schedule associated with a person.", | |||
| summary = "Returns plp the current induction schedule associated with a person.", | |||
There was a problem hiding this comment.
Minor, but on this and the next method, the summary tag reads weirdly.
Wonder if it should be something like:
Returns the current PLP Induction Schedule associated with a person.,
and
Returns the PLP Induction Schedule history associated with a person.
There was a problem hiding this comment.
ah yes - updated
| if (response.hasError(UpstreamApiError.Type.ENTITY_NOT_FOUND)) { | ||
| throw EntityNotFoundException("Could not find person with id: $hmppsId") | ||
| } | ||
| auditService.createEvent("GET_INDUCTION_SCHEDULE", mapOf("hmppsId" to hmppsId)) |
There was a problem hiding this comment.
I'm not sure how these events work / how strongly typed there are etc; but should the event name be plural perhaps? (or maybe it doesnt matter so much? 🤷♂️ )
There was a problem hiding this comment.
it's not typed at all, nor is there any guidance. I was thinking of keeping it simple with only considering INDUCTION or REVIEW schedules but I've updated this one to have _HISTORY
stevomcallister
dismissed
nathanrussell-moj-digital’s stale review
via
67987ee
No description provided.