[ESWE-1080] Expression-of-interest API #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickchoijd
changed the title
rickchoijd
requested changes
Jan 24, 2025
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/ExpressionOfInterestMessage.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/MessageType.kt
Outdated
Show resolved
Hide resolved
...otlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/ExpressionInterestService.kt
Outdated
Show resolved
Hide resolved
.../digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestControllerTest.kt
Outdated
Show resolved
Hide resolved
...uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/ExpressionOfInterestMessage.kt
Outdated
Show resolved
Hide resolved
...n/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/ExpressionInterestServiceTest.kt
Outdated
Show resolved
Hide resolved
...n/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/ExpressionInterestServiceTest.kt
Outdated
Show resolved
Hide resolved
...n/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/ExpressionInterestServiceTest.kt
Outdated
Show resolved
Hide resolved
rickchoijd
reviewed
Jan 24, 2025
...otlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/ExpressionInterestService.kt
Outdated
Show resolved
Hide resolved
rickchoijd
reviewed
Jan 24, 2025
rickchoijd
previously approved these changes
Jan 24, 2025
1) add back missing queue for local run 2) add back error log (cause) 3) add back missing `eventType` (message attribute) 4) rename queueId
rickchoijd
previously approved these changes
Jan 28, 2025
...uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/ExpressionOfInterestMessage.kt
Outdated
Show resolved
Hide resolved
wcdkj
reviewed
Jan 29, 2025
.../kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/exception/MessageFailedException.kt
Show resolved
Hide resolved
emmalanigan
requested changes
Jan 29, 2025
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...in/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestService.kt
Outdated
Show resolved
Hide resolved
rickchoijd
requested changes
Feb 6, 2025
...in/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestService.kt
Outdated
Show resolved
Hide resolved
...k/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestServiceTest.kt
Outdated
Show resolved
Hide resolved
...k/gov/justice/digital/hmpps/hmppsintegrationapi/services/PutExpressionInterestServiceTest.kt
Outdated
Show resolved
Hide resolved
|
This will be implementing a new pattern of decoupling incoming request to a message queue, which will be picked up by another HMPPS application (e.g. TAs have discussed it, and will be adding the pattern into documentation. |
stevomcallister
previously approved these changes
Feb 10, 2025
- fix type at `eventTypeCoe` (to `eventTypeCode` - use `eventTypeCode` on message body/payload, instead of enum name - use `type` on message attribute - revise relevant tests
rickchoijd
previously approved these changes
Feb 10, 2025
ben-madley-mt
requested changes
Feb 10, 2025
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/ExpressionInterestController.kt
Outdated
Show resolved
Hide resolved
rickchoijd
approved these changes
Feb 11, 2025
ben-madley-mt
approved these changes
Feb 11, 2025
emmalanigan
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.