Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ApiMockServer - a generic mock server to de-duplicate creation of mock servers #719

Merged
merged 18 commits into from
Mar 6, 2025
Merged

Create ApiMockServer - a generic mock server to de-duplicate creation of mock servers #719

merged 18 commits into from
Mar 6, 2025

Conversation

emmalanigan
Copy link
Contributor

Many of our mock servers do exactly the same thing, with the only difference being the port. By passing in the port, we can deduplicate the mock servers and create standard "stubForGet" and "stubForPost" responses.

emmalanigan added 17 commits March 4, 2025 17:04
@emmalanigan
add ApiMockServer as a generic mock server and use on incentives gate…
4be6778 
…way tests
@emmalanigan
switch prison visits gateway to use generic ApiMockServer
2859ce2
@emmalanigan
remove unused mock servers
e52afab
@emmalanigan
add create function to ApiMockServer and update Visits gateway and in…
30301e8 
…centives gateway to use it
@emmalanigan
remove adjudications and assessRisksAndNeeds mock servers
4f07a91
@emmalanigan
remove caseNotes mock server
6535dc1
@emmalanigan
remove personal relationships mock server
d8e659f
@emmalanigan
remove CVL mock server
1e31a2c
@emmalanigan
remove managePOM mock server
00088f1
@emmalanigan
remove ndelius mock server
48a5b7d
@emmalanigan
remove nomis mock server
a906d9a
@emmalanigan
remove non associations mock server
610b35a
@emmalanigan
remove prisonerOffenderSearch mock server
993137f
@emmalanigan
remove probationOffenderSearch mock server
1b58ee1
@emmalanigan
remove riskManagement mock server
1c66f57
@emmalanigan
remove EPF mock server; add EFFECTIVE_PROPOSAL_FRAMEWORK to Upstream …
d71e7e1 
…API model
@emmalanigan
rename genericMockServer as it is only used for webclientwrapper tests
46aca95
@emmalanigan emmalanigan marked this pull request as ready for review March 5, 2025 16:50
@emmalanigan emmalanigan merged commit d26579a into main Mar 6, 2025
11 checks passed
@emmalanigan emmalanigan deleted the EL-create-generic-mock-server branch March 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwatkins1994 tomwatkins1994 tomwatkins1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmalanigan @tomwatkins1994