Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMAI-286 Make LinkedPrisoner and PrisonerContactRestrictions models consistent with new naming #727

Merged
merged 5 commits into from
Mar 11, 2025
Merged

HMAI-286 Make LinkedPrisoner and PrisonerContactRestrictions models consistent with new naming #727

merged 5 commits into from
Mar 11, 2025

Conversation

BushraAbdullahi
Copy link
Contributor

No description provided.

@BushraAbdullahi BushraAbdullahi changed the title Make LinkedPrisoner and PrisonerContactRestrictions models consistent with new naming HMAI-286 Make LinkedPrisoner and PrisonerContactRestrictions models consistent with new naming Mar 7, 2025
@BushraAbdullahi BushraAbdullahi marked this pull request as ready for review March 7, 2025 11:20
tomwatkins1994
tomwatkins1994 requested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@tomwatkins1994 tomwatkins1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PRLinkedPrisoner.kt file has been renamed but the classes within are still as before. Think you just need to go into the file and rename them manually

tomwatkins1994
tomwatkins1994 requested changes Mar 7, 2025
View reviewed changes
...v/justice/digital/hmpps/hmppsintegrationapi/models/personalRelationships/PRLinkedPrisoner.kt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just LinkedPrisonerRelationship left to do in this file pls

emmalanigan
emmalanigan reviewed Mar 10, 2025
View reviewed changes
...ps/hmppsintegrationapi/models/personalRelationships/PRPrisonerContactRestrictionsResponse.kt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this doing differently to the PRPrisonerContactRestrictions?

@tomwatkins1994 tomwatkins1994 merged commit 265f394 into main Mar 11, 2025
11 checks passed
@tomwatkins1994 tomwatkins1994 deleted the HMAI-286-make-linked-prisoner-and-prisoner-contact-restrictions-models-consistent-with-new-naming branch March 11, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmalanigan emmalanigan emmalanigan left review comments

@tomwatkins1994 tomwatkins1994 tomwatkins1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BushraAbdullahi @tomwatkins1994 @emmalanigan