Added prison filter to get person risk category endpoint #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmalanigan
reviewed
Mar 11, 2025
.../justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/RiskCategoriesController.kt
Show resolved
Hide resolved
| if (nomisNumber != null) { | ||
| personRiskCategories = nomisGateway.getRiskCategoriesForPerson(id = nomisNumber) | ||
| if (personResponse.data?.nomisNumber != null) { | ||
| personRiskCategories = nomisGateway.getRiskCategoriesForPerson(id = personResponse.data.nomisNumber) |
There was a problem hiding this comment.
We've been doing something like this on the other service layers
val nomisNumber = personResponse.data?.nomisNumber ?: return Response( data = emptyList(), errors = listOf(UpstreamApiError(UpstreamApi.NOMIS, UpstreamApiError.Type.ENTITY_NOT_FOUND)), )
Are we potentially missing handling that error this way?
There was a problem hiding this comment.
this is mirroring existing behavior, anxious to change this in the case of something using it as is - we should talk about this
There was a problem hiding this comment.
Looks like we get a 404 back from offender search that gets passed back by the gateway
...tice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/RiskCategoriesControllerTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.