updating confirm match request parameters

Author: lalithanagarur

src/main/kotlin/uk/gov/justice/digital/hmpps/learnerrecordsapi/models/request/ConfirmMatchRequest.kt

@@ -6,26 +6,26 @@ import uk.gov.justice.digital.hmpps.learnerrecordsapi.models.db.MatchEntity
 class ConfirmMatchRequest(
 
   @field:Pattern(regexp = "^[0-9]{1,10}\$")
-  val matchingUln: String,
+  val matchingUln: String? = null,
 
   @field:Pattern(regexp = "^[A-Za-z' ,.-]{3,35}$")
-  val givenName: String,
+  val givenName: String? = null,
 
   @field:Pattern(regexp = "^[A-Za-z' ,.-]{3,35}$")
-  val familyName: String,
+  val familyName: String? = null,
 
-  val matchType: MatchType? = null,
+  val matchType: MatchType,
 
-  val countOfMatchedUlns: String? = null,
+  val countOfMatchedUlns: String,
 
 ) {
   fun asMatchEntity(nomisId: String): MatchEntity = MatchEntity(
     null,
     nomisId,
-    matchingUln,
-    givenName,
-    familyName,
+    matchingUln.orEmpty(),
+    givenName.orEmpty(),
+    familyName.orEmpty(),
     matchType.toString(),
-    countOfMatchedUlns.orEmpty(),
+    countOfMatchedUlns,
   )
 }

src/test/kotlin/uk/gov/justice/digital/hmpps/learnerrecordsapi/service/MatchServiceTest.kt

@@ -22,8 +22,6 @@ class MatchServiceTest {
   private val matchedUln = "a1234"
   private val givenName = "John"
   private val familyName = "Smith"
-  private val dateOfBirth = LocalDate.now().toISOFormat()
-  private val gender = Gender.MALE.name
 
   private lateinit var mockMatchRepository: MatchRepository
   private lateinit var matchService: MatchService