fix tests

ministryofjustice · Mar 10, 2025 · cd88fd2 · cd88fd2
1 parent 16019f7
commit cd88fd2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/integration_tests/e2e/forward-swap-visiting-orders-for-pin-credit-application.cy.ts b/integration_tests/e2e/forward-swap-visiting-orders-for-pin-credit-application.cy.ts
@@ -7,7 +7,7 @@ context('Forward Application Page', () => {
   const { prisonerApp: application } = new TestData()
   const {
     id: applicationId,
-    requestedBy: { id: prisonerId },
+    requestedBy: { username: prisonerId },
   } = application
 
   const visitPage = () => {

diff --git a/integration_tests/e2e/view-swap-visiting-orders-for-pin-credit-application.cy.ts b/integration_tests/e2e/view-swap-visiting-orders-for-pin-credit-application.cy.ts
@@ -7,7 +7,7 @@ context('View Swap VOs for PIN Credit Application Page', () => {
   const { prisonerApp: application } = new TestData()
   const {
     id: applicationId,
-    requestedBy: { id: prisonerId },
+    requestedBy: { username: prisonerId },
   } = application
 
   beforeEach(() => {

diff --git a/server/@types/managingAppsApi.ts b/server/@types/managingAppsApi.ts
@@ -13,9 +13,11 @@ export interface AssignedGroup {
 }
 
 export interface RequestedBy {
-  id: string
+  username: string
+  userId: string
   firstName: string
   lastName: string
+  category: string
   location: string
   iep: string
 }

diff --git a/server/routes/testutils/testData.ts b/server/routes/testutils/testData.ts
@@ -13,15 +13,17 @@ export default class TestData {
         id: 'ABC',
         name: 'HMP ABC',
       },
-      initialApp: 'SWAP_VISITING_ORDERS_FOR_PIN_CREDIT',
+      initialApp: 'PIN_PHONE_CREDIT_SWAP_VISITING_ORDERS',
       type: 'DEPARTMENT',
       email: 'business+hub+ABC@justice.gov.uk',
     },
-    appType: 'SWAP_VISITING_ORDERS_FOR_PIN_CREDIT',
+    appType: 'PIN_PHONE_CREDIT_SWAP_VISITING_ORDERS',
     requestedBy: {
-      id: 'G123456',
+      username: 'G123456',
+      userId: 'cb42921f-3b33-4efa-a873-4a1d86eb6caa',
       firstName: 'Emily',
       lastName: 'Brown',
+      category: 'PRISONER',
       location: 'C-2-013',
       iep: 'Enhanced',
     },