Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating njk template for log swap vos pin credit details page #16

Merged

Conversation

sweetymj
Copy link
Contributor

@sweetymj sweetymj commented Feb 4, 2025

This PR;

  • creates the .njk template for the swap VOs for PIN credit details logging page
    RA-208

@@ -11,5 +13,44 @@
text: "Back",
href: "/log/prisoner-details"
}) }}
</div>

<span class="govuk-caption-xl">{{ appTypeTitle }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is about indenting as it's a bit random.


</div>


{% endblock %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing newline

Copy link
Contributor

@madebyzak madebyzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sweetymj sweetymj merged commit a31139d into main Feb 4, 2025
8 checks passed
@sweetymj sweetymj deleted the feature/RA-246-create-log-swap-vos-details-njk-template branch February 4, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants