Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRC-439: Integration tests and handling conflicts #10

Merged
merged 2 commits into from
Feb 21, 2025
Merged

PRC-439: Integration tests and handling conflicts #10

merged 2 commits into from
Feb 21, 2025

Conversation

timharrison-moj
Copy link
Contributor

This PR:

  • Adds integration test cases for roles, create, get, update, delete and handling conflicts.
  • Now checks that the appropriate events are emitted (or not) on each action.
  • Tidies/groups the swagger docs into neater sections (with tags)
  • Handles conflicts when attempting to create an organisations with a fixed ID that exists
  • Properties and env vars to feature switch SNS events and individual events

james-baker-moj
james-baker-moj reviewed Feb 21, 2025
View reviewed changes
...in/uk/gov/justice/digital/hmpps/organisationsapi/resource/sync/SyncOrganisationController.kt
@@ -27,7 +27,7 @@ import uk.gov.justice.digital.hmpps.organisationsapi.model.response.sync.SyncOrg
import uk.gov.justice.digital.hmpps.organisationsapi.swagger.AuthApiResponses
import uk.gov.justice.hmpps.kotlin.common.ErrorResponse

@Tag(name = "Sync & Migrate")
@Tag(name = "Migration and synchronisation")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this you need to change OpenApiConfiguration as well. The tags have to match so it orders them correctly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see it was changed for orgs already

james-baker-moj
james-baker-moj approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@james-baker-moj james-baker-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timharrison-moj timharrison-moj merged commit aa14e3a into main Feb 21, 2025
8 checks passed
@timharrison-moj timharrison-moj deleted the PRC-439_sync_organisation_integration_tests branch February 21, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-baker-moj james-baker-moj james-baker-moj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timharrison-moj @james-baker-moj