PRC-507: Address phones bug on get organisation.

[timharrison-moj]

Fixes a bug where all addresses included the phone numbers for all other addresses in this organisation.
The mapping between organisation address phones and organisation phones was not quite strict enough.

I am now thinking that the simpler, and clearer, solution for address-phones is to hold them separately (for both contacts and organisations) from global phones. So we'd have organisation-global-phones and organisation-address-phones as distinct tables, each containing the phone-type, phone-number and ext-number, plus the audit columns. The problem at the moment is that there is no simple way to get JUST the global phone numbers, as to do so, we need to get all phone numbers and then filter out the address-specific phone numbers, which leads to complexity and lack of clarity in the code, which I think is unnecessary.

[prabash-moj]

It looks like there is very weak unit tests for OrganisationService, Would be worth if the unit tests were strong and test all possible cases there, I think it may be easy to test it as part of integration tests, Here we test the get method indirectly by using get call as part of integration tests?

[timharrison-moj]

This was a bug ticket - so a fix was required. I wanted to reproduce the error, which I did by adding a second address to this integration test. Initially this failed, because the single address phone number - linked to only one address - was showing up on both addresses. I then fixed the code until the test passed. I take your point about the organisation service not having lots of unit tests though, but its something to take forward on another ticket I think?