CDPS-1071 Make some properties of religion update request optional

Author: scottrowley

src/main/kotlin/uk/gov/justice/digital/hmpps/personintegrationapi/personprotectercharacteristics/dto/request/ReligionV1RequestDto.kt

@@ -16,24 +16,20 @@ data class ReligionV1RequestDto(
   @Schema(
     description = "Reason for the religion change",
     example = "Religion has changed",
-    required = false,
-    nullable = false,
+    nullable = true,
   )
-  val reasonForChange: String,
+  val reasonForChange: String?,
 
   @Schema(
     description = "The date the religious belief is valid from",
-    required = true,
-    nullable = false,
+    nullable = true,
   )
-  val effectiveFromDate: LocalDate,
+  val effectiveFromDate: LocalDate?,
 
   @Schema(
     description = "Boolean indicating if the religious belief has been verified.",
     example = "false",
     defaultValue = "false",
-    required = true,
-    nullable = false,
   )
   val isVerified: Boolean,
 )

src/test/kotlin/uk/gov/justice/digital/hmpps/personintegrationapi/personprotectercharacteristics/resource/PersonProtectedCharacteristicsV1ResourceIntTest.kt

@@ -56,6 +56,17 @@ class PersonProtectedCharacteristicsV1ResourceIntTest : IntegrationTestBase() {
           .exchange()
           .expectStatus().isNoContent
       }
+
+      @Test
+      fun `can update a persons religion by prisoner number - minimal request example`() {
+        webTestClient.put()
+          .uri("v1/person-protected-characteristics/religion?prisonerNumber=$PRISONER_NUMBER")
+          .contentType(MediaType.APPLICATION_JSON)
+          .headers(setAuthorisation(roles = listOf(PersonProtectedCharacteristicsRoleConstants.PROTECTED_CHARACTERISTICS_READ_WRITE_ROLE)))
+          .bodyValue(MINIMAL_RELIGION_REQUEST_DTO)
+          .exchange()
+          .expectStatus().isNoContent
+      }
     }
 
     @Nested
@@ -125,6 +136,14 @@ class PersonProtectedCharacteristicsV1ResourceIntTest : IntegrationTestBase() {
         false,
       )
 
+    val MINIMAL_RELIGION_REQUEST_DTO =
+      ReligionV1RequestDto(
+        "AGNO",
+        null,
+        null,
+        false,
+      )
+
     const val TEST_DOMAIN = "RELIGION"
   }
 }