Visual regression testing #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexw-moj
reviewed
Dec 16, 2024
There was a problem hiding this comment.
There's more bits in the collapsed sections which we also want to compare?
Izzy found a nice .click({ multiple: true }) for the accordion sections.
There was a problem hiding this comment.
Yes, I think this is only the foundations - really the visual regression tests need integrating into the main tests in the same way as the accessibility ones I think.
| @@ -137,6 +137,8 @@ | |||
| "cookie-session": "^2.1.0", | |||
| "cypress": "^13.16.0", | |||
| "cypress-axe": "^1.5.0", | |||
| "cypress-image-diff-html-report": "^2.2.0", | |||
There was a problem hiding this comment.
What's the HTML report for? presumably just for seeing the results in the pipeline right?
There was a problem hiding this comment.
Oh good question, I didn't actually set that up properly. Details are here: https://github.com/kien-ht/cypress-image-diff-html-report?tab=readme-ov-file#overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the framework and a sample file for running visual regression testing.