generated from ministryofjustice/hmpps-template-typescript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual regression testing #319
Open
pipwilson
wants to merge
7
commits into
main
Choose a base branch
from
visual-regression-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa2b86e
Initial visual regression testing
pipwilson ae5dd10
Add initial baseline images
pipwilson 0ff5f5e
Add all visual test results to circle artifacts
pipwilson a1b9b38
Set a custom failure threshold for visual regression tests
pipwilson 2947c53
Merge branch 'main' into visual-regression-testing
Thomas-Geraghty f30cc23
Have a go at generating the HTML report for the visual diff
pipwilson 88776e8
Revert makefile change
pipwilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+255 KB
cypress-image-diff-screenshots/baseline/visual-comparison.cy.ts-about-page.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+172 KB
...ss-image-diff-screenshots/baseline/visual-comparison.cy.ts-create-goal-page.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+92.5 KB
...s-image-diff-screenshots/baseline/visual-comparison.cy.ts-plan-history-page.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+115 KB
cypress-image-diff-screenshots/baseline/visual-comparison.cy.ts-plan-page.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
const config = { | ||
FAILURE_THRESHOLD: 0.05, // 5% difference allowed | ||
} | ||
|
||
module.exports = config |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
describe('Rendering of pages we can GET', () => { | ||
before(() => { | ||
cy.createSentencePlan().then(planDetails => { | ||
cy.wrap(planDetails).as('plan') | ||
cy.openSentencePlan(planDetails.oasysAssessmentPk) | ||
}) | ||
}) | ||
|
||
it('take plan page screenshot', () => { | ||
cy.visit('/plan') | ||
cy.compareSnapshot('plan-page') | ||
}) | ||
|
||
it('take create goal page screenshot', () => { | ||
cy.visit('/create-goal/accommodation') | ||
cy.compareSnapshot('create-goal-page') | ||
}) | ||
|
||
it('take plan history page screenshot', () => { | ||
cy.visit('/plan-history') | ||
cy.compareSnapshot('plan-history-page') | ||
}) | ||
|
||
it('take about page screenshot', () => { | ||
cy.visit('/about') | ||
cy.compareSnapshot('about-page') | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's more bits in the collapsed sections which we also want to compare?
Izzy found a nice
.click({ multiple: true })
for the accordion sections.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is only the foundations - really the visual regression tests need integrating into the main tests in the same way as the accessibility ones I think.