Adding tests for maintenance mode pages

Author: said-moj

.github/workflows/test.yml

@@ -23,10 +23,15 @@ jobs:
       run: |
         python -m pip install --upgrade pip
         python -m pip install -r requirements/generated/requirements-development.txt
+        
 
     - name: Unit test with pytest
       run: |
         pip install pytest pytest-cov
+        # This is required because at the moment the assets are being built in the app
+        # When the app tries to access sass files in node_modules it will fail unless this is included
+        npm install
+        
         coverage run -m pytest tests/unit_tests
         coverage xml
 

app/static/src/scss/custom.scss

@@ -1,5 +1,5 @@
 /* Example of a custom SCSS file which is combined into one SCSS application file by Flask Assets */
-@import "node_modules/govuk-frontend/dist/govuk/settings/index";
+@import "node_modules/govuk-frontend/dist/govuk/settings/index.css";
 
 /* Example below of using GOVUK frontend SCSS variables in custom SCSS */
 .moj-skeleton {

app/static/src/scss/govuk-frontend.scss

@@ -1,5 +1,5 @@
 /* Import GOVUK frontend SCSS to be compiled to CSS */
-@import "node_modules/govuk-frontend/dist/govuk/all";
+@import "node_modules/govuk-frontend/dist/govuk/all.css";
 
 /* Import your custom SCSS below to be compiled into one by Flask Assets */
 @import "./custom";

tests/unit_tests/conftest.py

@@ -0,0 +1,22 @@
+import pytest
+from app import Config
+from app import create_app
+
+
+class TestConfig(Config):
+    TESTING = True
+    DEBUG = True
+    SERVER_NAME = "localhost"
+    RATELIMIT_ENABLED = False
+    SECRET_KEY = "TEST_KEY"
+
+
+@pytest.fixture(scope="session")
+def app():
+    app = create_app(TestConfig)
+    yield app
+
+
+@pytest.fixture()
+def client(app):
+    return app.test_client()

tests/unit_tests/test_example.py

@@ -0,0 +1,15 @@
+def test_maintenance_page_on(app, client):
+    app.config["MAINTENANCE_MODE"] = True
+    response = client.get("/")
+    assert response.status_code == 302
+    assert response.headers["location"] == "/maintenance-mode"
+    response = client.get("/", follow_redirects=True)
+    assert response.status_code == 503
+    assert response.request.path == "/maintenance-mode"
+
+
+def test_maintenance_page_off(app, client):
+    app.config["MAINTENANCE_MODE"] = False
+    response = client.get("/maintenance-mode", follow_redirects=True)
+    assert response.status_code == 200
+    assert response.request.path == "/"