Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA 3486: Re-create means test savings page #111

Merged
merged 87 commits into from
Feb 3, 2025
Merged

LGA 3486: Re-create means test savings page #111

merged 87 commits into from
Feb 3, 2025

Conversation

BenMillar-MOJ
Copy link
Collaborator

@BenMillar-MOJ BenMillar-MOJ commented Jan 31, 2025 •
edited
Loading

What does this pull request do?

Adds the savings form

Screenshot 2025-01-31 at 00 28 30 Screenshot 2025-01-31 at 00 24 56

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

BenMillar-MOJ and others added 30 commits January 6, 2025 10:05
@BenMillar-MOJ
Add about you page
e74f39c
@BenMillar-MOJ
Support govuk-frontend on body
0385d22
@BenMillar-MOJ
Add do you receive benefits question
2a46018
@BenMillar-MOJ
Add the additional questions
5fbb9d9
@BenMillar-MOJ
Merge remote-tracking branch 'origin/main' into feature/LGA-3482-Re-c…
d3a9076 
…reate-means-test-about-you

# Conflicts:
#	app/__init__.py
#	app/static/src/scss/styles.scss
@BenMillar-MOJ
Add means test link
0e724b9
@BenMillar-MOJ
Add conditional integer questions
5b14dcb
@BenMillar-MOJ
Safely load category from session
6694a61
@BenMillar-MOJ
Add form validation
1822ace
@BenMillar-MOJ
Send About You payload to cla_backend
fb0c9a7
@BenMillar-MOJ
Implement benefits page and backend payload
68a422f
@BenMillar-MOJ
Add is_eligible endpoint
0a28dec
@TawneeOwl
Add property placeholder
663640e
@TawneeOwl
Update property placeholder
7200b92
@TawneeOwl
Update property formatting
a59a5c7
@BenMillar-MOJ
Add below form content
200df0b
@BenMillar-MOJ
Add valuables info
5742ee9
@BenMillar-MOJ
Update get next page and add unit tests
126fc4c
@said-moj @BenMillar-MOJ
Create a forms package for means test forms (#97)
b20f46f 
* Create a forms package for means test forms

* Add property form back in

* Add property form to list of forms

---------

Co-authored-by: Ben Millar <ben.millar@digital.justice.gov.uk>
@TawneeOwl
Add tests
3323a37
@BenMillar-MOJ
Add money field
ab1f74e
@BenMillar-MOJ
Merge remote-tracking branch 'origin/feature/LGA-3482-Re-create-means…
3f8b9d9 
…-test-about-you' into feature/LGA-3482-Re-create-means-test-about-you
@TawneeOwl
WIP Session expiry
a7c22db
@TawneeOwl
Update session expiry
7f74570
@TawneeOwl
Add traversal prevention
89b5286
@BenMillar-MOJ
Update eligibility to not share fields between instances
f860c2b
@BenMillar-MOJ
Mark strings as translatable
0d7ebaa
@BenMillar-MOJ
Update money field to work with partners
8f808ee
@BenMillar-MOJ
Add conditional-questions.js
715f88c
@BenMillar-MOJ
Add Welsh translations
2785f3b
@BenMillar-MOJ BenMillar-MOJ requested a review from a team as a code owner January 31, 2025 00:24
TawneeOwl
TawneeOwl approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenMillar-MOJ BenMillar-MOJ merged commit 716e53e into main Feb 3, 2025
10 of 12 checks passed
@BenMillar-MOJ BenMillar-MOJ deleted the feature/LGA-3486-Re-create-means-test-savings-page branch February 3, 2025 13:02
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 5, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: Invalid value for amount potato (<class 'str'>) means_test.income View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@said-moj said-moj said-moj approved these changes

@TawneeOwl TawneeOwl TawneeOwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMillar-MOJ @said-moj @TawneeOwl