Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-3495 - Add means test answers to the reviews page #113

Merged
merged 44 commits into from
Mar 10, 2025
Merged

LGA-3495 - Add means test answers to the reviews page #113

merged 44 commits into from
Mar 10, 2025

Conversation

said-moj
Copy link
Contributor

@said-moj said-moj commented Feb 3, 2025 •
edited
Loading

What does this pull request do?

Add means test answers to the reviews page.
Store only the category code in session
Create a new CategoryAnswer model to hold category and onward questions answers

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@said-moj said-moj requested a review from a team as a code owner February 3, 2025 16:45
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from 19345ee to 80d9573 Compare February 4, 2025 10:06
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from 80d9573 to b5cd6bc Compare February 4, 2025 10:21
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from 8b41743 to a256379 Compare February 5, 2025 10:00
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from a256379 to bcb2520 Compare February 5, 2025 10:10
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from d49299e to a4487f4 Compare February 5, 2025 16:42
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from a4487f4 to fbf5be0 Compare February 5, 2025 16:44
said-moj added 23 commits March 7, 2025 08:56
@said-moj
Add functional tests for check your answers page
0420b01
@said-moj
Fix failing unit tests
a2e3584
@said-moj
Add more functional tests for check your answers page
0e8a9b9
@said-moj
Update heading for the review your answers page
29f2e37
@said-moj
Update unit tests to reflect new categories landing page path
6c99177
@said-moj
Add welsh translation for check your answers page
13bca7e
@said-moj
Skip conditional fields that have not triggered
7eae0bc
@said-moj
Add comments to BaseMeansTestForm.summary
4d03f5b
@said-moj
Add unit tests for app.means_test.forms.BaseMeansTestForm.is_unvalida…
126f344 
…ted_conditional_field
@said-moj
Rename choices filter for better documentation
338be28
@said-moj
Use MoneyField._value to get formatted answer for MoneyField instances
a6c1d84
@said-moj
Remove superfluous comment about form states
380dc0f
@said-moj
Add docstring for BaseMeansTestForm.summary
7a7aa48
@said-moj
Format multiple onward pages answers into separate lines
9cc621c
@said-moj
Update item using .value.update instead of __setitem__
41a6d69
@said-moj
Add comment explaining how \n are converted to html breaks
391de00
@said-moj
Add docstring for CategoryLandingPage.listing
b6dc1d2
@said-moj
Use list for typing instead of []
d5a128c
@said-moj
Translate check your answers page title
7d9161d
@said-moj
Add extra docs for BaseMeansTestForm.get_selected_answer
c816e67
@said-moj
Only save the category code in session and reconstruct it when its ne…
86b1059 
…eded
@said-moj
Fix failing unit tests
3bbfbb2
@said-moj
Make Eligibility.__init__ notes parameter optional
1b85cc7
@said-moj said-moj force-pushed the feature/LGA-3495-means-test-review branch from c2b9470 to 1b85cc7 Compare March 7, 2025 08:56
BenMillar-MOJ
BenMillar-MOJ approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@BenMillar-MOJ BenMillar-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for all your work on this!

@said-moj said-moj merged commit 95e6cd7 into main Mar 10, 2025
11 of 12 checks passed
@said-moj said-moj deleted the feature/LGA-3495-means-test-review branch March 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TawneeOwl TawneeOwl TawneeOwl approved these changes

@BenMillar-MOJ BenMillar-MOJ BenMillar-MOJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@said-moj @TawneeOwl @BenMillar-MOJ