Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-3531: Add ModSec rules from CLA_Public #151

Merged
merged 3 commits into from
Feb 26, 2025
Merged

LGA-3531: Add ModSec rules from CLA_Public #151

merged 3 commits into from
Feb 26, 2025

Conversation

BenMillar-MOJ
Copy link
Collaborator

What does this pull request do?

  • Adds the ModSec config from CLA Public, disabling rules which cause a large number of false positives.

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@BenMillar-MOJ BenMillar-MOJ requested a review from a team as a code owner February 23, 2025 23:53
TawneeOwl
TawneeOwl reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some small comments next to the rules with a brief description?

@BenMillar-MOJ
Copy link
Collaborator Author

Could we add some small comments next to the rules with a brief description?

I have added comments explaining each rule.

TawneeOwl
TawneeOwl approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenMillar-MOJ BenMillar-MOJ merged commit 92ff0dd into main Feb 26, 2025
3 checks passed
@BenMillar-MOJ BenMillar-MOJ deleted the LGA-3531-Copy-modsec-rules-from-cla-public branch February 26, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@said-moj said-moj said-moj approved these changes

@TawneeOwl TawneeOwl TawneeOwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMillar-MOJ @said-moj @TawneeOwl