Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky new tabs tests #185

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Fix flaky new tabs tests #185

merged 2 commits into from
Mar 6, 2025

Conversation

BenMillar-MOJ
Copy link
Collaborator

What does this pull request do?

  • New tab tests now check that onward links open in a new tab by asserting they have target=_blank rather than opening them

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@BenMillar-MOJ BenMillar-MOJ requested a review from a team as a code owner March 6, 2025 10:19
TawneeOwl
TawneeOwl approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this so quick!

@BenMillar-MOJ BenMillar-MOJ merged commit fec3c70 into main Mar 6, 2025
12 checks passed
@BenMillar-MOJ BenMillar-MOJ deleted the fix/flaky-next-steps-tests branch March 6, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@said-moj said-moj said-moj approved these changes

@TawneeOwl TawneeOwl TawneeOwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMillar-MOJ @said-moj @TawneeOwl