Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-3535 - Add traversal protection #186

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

LGA-3535 - Add traversal protection #186

wants to merge 52 commits into from

Conversation

said-moj
Copy link
Contributor

@said-moj said-moj commented Mar 6, 2025 •
edited
Loading

What does this pull request do?

Protect legal aid available page to categories that are eligible only
Protect eligible contact page only when means test has been passed

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • [x[ Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@said-moj said-moj requested a review from a team as a code owner March 6, 2025 14:58
@said-moj said-moj force-pushed the feature/LGA-3535-traversal-protection branch from e2363f5 to 738b128 Compare March 10, 2025 09:39
@said-moj said-moj force-pushed the feature/LGA-3535-traversal-protection branch from abb881a to c065e36 Compare March 10, 2025 14:16
@said-moj said-moj changed the title WIP - LGA-3535 - Add traversal protection LGA-3535 - Add traversal protection Mar 11, 2025
@said-moj said-moj force-pushed the feature/LGA-3535-traversal-protection branch from 01379b0 to 615c27e Compare March 11, 2025 14:35
said-moj added 24 commits March 11, 2025 15:49
@said-moj
Skip conditional fields that have not triggered
b2a4361
@said-moj
Add comments to BaseMeansTestForm.summary
620d5cc
@said-moj
Add unit tests for app.means_test.forms.BaseMeansTestForm.is_unvalida…
f322c13 
…ted_conditional_field
@said-moj
Rename choices filter for better documentation
5f00633
@said-moj
Use MoneyField._value to get formatted answer for MoneyField instances
6e79e23
@said-moj
Remove superfluous comment about form states
94fe265
@said-moj
Add docstring for BaseMeansTestForm.summary
c06823b
@said-moj
Format multiple onward pages answers into separate lines
c191967
@said-moj
Update item using .value.update instead of __setitem__
c659d42
@said-moj
Add comment explaining how \n are converted to html breaks
d9577f2
@said-moj
Add docstring for CategoryLandingPage.listing
aad734b
@said-moj
Use list for typing instead of []
20404f3
@said-moj
Translate check your answers page title
d15528f
@said-moj
Add extra docs for BaseMeansTestForm.get_selected_answer
dcf1841
@said-moj
Only save the category code in session and reconstruct it when its ne…
6c47f9c 
…eded
@said-moj
Fix failing unit tests
0571a62
@said-moj
Add in_scope Category field and set it for categories that are in_scope
6e29c85
@said-moj
Protect legal aid available page to categorys that are eligible only
8577847
@said-moj
Add means test form protection
76f05d3
@said-moj
Add documentation for MeansTest.ensure_form_protection
6bcb544
@said-moj
Enforce onward questions order
3088ac2
@said-moj
Fix means_test.views.CheckYourAnswers.post to redirect the correct pa…
b3415f9 
…ge after means
@said-moj
Add unit tests for session.in_scope
39fb035
@said-moj
/review can only be access when a category is in scope
5b79b09
@said-moj said-moj force-pushed the feature/LGA-3535-traversal-protection branch from 615c27e to e7fe89f Compare March 11, 2025 15:50
@said-moj said-moj force-pushed the feature/LGA-3535-traversal-protection branch from e7fe89f to 1ddd7fa Compare March 11, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@said-moj