Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGA-3267: Add Ruff Format to the pipeline #25

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

BenMillar-MOJ
Copy link
Collaborator

@BenMillar-MOJ BenMillar-MOJ commented Aug 23, 2024

What does this pull request do?

  • Adds ruff format --check to the CI pipeline so the static-analysis job will fail if the files are formatted incorrectly.

  • Reformats all the files, this does mean this PR is hard to review, to review the non-format changes please run the following:

git diff main cc27375964749ee652490b7e8da3f20c471abae3

cc27375 was the last commit made before the files were re-formatted.

Any other changes that would benefit highlighting?

  • Updates the Ruff version to v0.6.2, which is the latest version released.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@BenMillar-MOJ BenMillar-MOJ merged commit 971437f into main Aug 28, 2024
10 checks passed
@BenMillar-MOJ BenMillar-MOJ deleted the bug/LGA-3267-Fix-ruff-formatter branch August 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants