Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions, deduplicate tests #37

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Update actions, deduplicate tests #37

merged 5 commits into from
Feb 17, 2025

Conversation

farrell-m
Copy link
Contributor

@farrell-m farrell-m commented Feb 11, 2025 •
edited
Loading

  • Bump to latest SB common library version
    • Fixed bug where duplicate unit tests would run twice in pipelines (build would run tests, followed by jacocoTestVerification)
  • Workflows
    • Replace deprecated gradle-build-action with setup-gradle action
    • Upload checkstyle, test and jacoco coverage artifacts
    • Fixed bug where test coverage verification would run without jacoco report (effectively always passing)

PhilDigitalJustice
PhilDigitalJustice approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrell-m farrell-m merged commit 1bdd7ff into main Feb 17, 2025
2 checks passed
@farrell-m farrell-m deleted the update-versions branch February 17, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilDigitalJustice PhilDigitalJustice PhilDigitalJustice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farrell-m @PhilDigitalJustice