Update to Rails 7.1 #2822
Open
Update to Rails 7.1 #2822
+528
−400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
from
eb3a5b7 to
c2f801e
Compare
alexdesi
commented
Mar 10, 2025
docker/Dockerfile
Outdated
| && bundle config --global without test development \ | ||
| && bundle config build.nokogiri --use-system-libraries \ | ||
| && bundle check || bundle install --jobs=4 --retry=3 | ||
| # RUN gem install bundler -v $(cat Gemfile.lock | tail -1 | tr -d " ") \ |
There was a problem hiding this comment.
todo: Revert this as unique cmd
patrick-laa
previously approved these changes
Mar 10, 2025
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
from
30cc21b to
dea60fd
Compare
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
from
dea60fd to
2c77289
Compare
This reverts commit 1539a37.
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
3 times, most recently
from
3e2020c to
047de41
Compare
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
from
047de41 to
19a321c
Compare
This reverts commit c534542.
alexdesi
force-pushed
the
ACD-588-update-rails-7.2
branch
from
631de55 to
ae568d1
Compare
|
patrick-laa
reviewed
Mar 11, 2025
| end | ||
|
|
||
| # see https://github.com/shadabahmed/logstasher | ||
| config.logstasher.enabled = true |
There was a problem hiding this comment.
Are we deliberately switching off logstasher in production?
There was a problem hiding this comment.
no,
I think rails update removed it, and I forgot to put it back
alexdesi
commented
Mar 11, 2025
Comment on lines
-67
to
-84
| # Log disallowed deprecations. | ||
| config.active_support.disallowed_deprecation = :log | ||
|
|
||
| # Tell Active Support which deprecation messages to disallow. | ||
| config.active_support.disallowed_deprecation_warnings = [] | ||
|
|
||
| # Use default logging formatter so that PID and timestamp are not suppressed. | ||
| config.log_formatter = Logger::Formatter.new | ||
|
|
||
| # Use a different logger for distributed setups. | ||
| # require "syslog/logger" | ||
| # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name') | ||
|
|
||
| if ENV.fetch('RAILS_LOG_TO_STDOUT', nil).present? | ||
| logger = ActiveSupport::Logger.new($stdout) | ||
| logger.formatter = config.log_formatter | ||
| config.logger = ActiveSupport::TaggedLogging.new(logger) | ||
| end |
There was a problem hiding this comment.
I think we should revert these line back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
for consistency and "zeitwerk" name convention
Why
To keep VCD updated and secure