Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPT-2200 Remove Early bird question number hyperlinks #1122

Closed

Conversation

njpreddy
Copy link
Contributor

@njpreddy njpreddy commented Nov 7, 2024

Description

Remove hyperlinks around question UINs displayed on the early bird dashboard.

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...

Screenshots

Before
eb-hyperlinked

After
eb-hyperlink-removed

Related JIRA tickets

https://dsdmoj.atlassian.net/jira/software/c/projects/CDPT/boards/864?assignee=557058%3A2d2f4a33-f427-483f-9c36-338caee60eae&selectedIssue=CDPT-2200

Deployment

Manual testing instructions

See the 'early bird' page by going to:
Settings => Early bird list => Early bird preview
From there you should be able to see the links are gone from each question UIN. You should also see the same by clicking on the link in the "New PQs to be allocated today" email, if you are a subscriber.

@njpreddy njpreddy marked this pull request as ready for review November 8, 2024 12:13
@njpreddy njpreddy requested review from a team as code owners November 8, 2024 12:13
dump.rdb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something my local redis has produced ... now deleted

@njpreddy njpreddy closed this Nov 8, 2024
@njpreddy njpreddy deleted the cdpt-2200-remove-early-bird-question-number-hyperlinks branch November 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants