PI-1449 Fix search suggestions for multi-term queries (#32)

ministryofjustice · Sep 22, 2023 · 37587b3 · 37587b3
1 parent 4f6decc
commit 37587b3
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 6,802 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/probation-search-frontend/components/probationSearch/template.njk b/packages/probation-search-frontend/components/probationSearch/template.njk
@@ -29,8 +29,8 @@
                 Did you mean
                 {%- set comma = joiner() %}
                 {%- for suggestion in params.results.suggestions %}{{ comma() }}
-                    <a href="?q={{ suggestion }}" class="govuk-link govuk-link--no-visited-state"
-                       title="Search again using {{ suggestion }}">{{ suggestion }}</a>
+                    <a href="{{ suggestion.url }}" class="govuk-link govuk-link--no-visited-state"
+                       title="Search again using {{ suggestion.text }}">{{ suggestion.text }}</a>
                 {%- endfor %}?
             {% endif %}
         </p>
@@ -46,7 +46,8 @@
               document.getElementById("{{ params.id }}").addEventListener('input', function() {
                 clearTimeout(timeoutId)
                 const url = new URL(location.href)
-                url.searchParams.forEach((value, name) => url.searchParams.delete(name))
+                url.searchParams.delete("matchAllTerms")
+                url.searchParams.delete("providers[]")
                 url.searchParams.set('q', this.value)
                 timeoutId = setTimeout(() => fetch(url).then(async response => {
                   if (response.status === 200) {

diff --git a/packages/probation-search-frontend/data/probationSearchClient.ts b/packages/probation-search-frontend/data/probationSearchClient.ts
@@ -109,6 +109,8 @@ export interface ProbationSearchResult {
 
 export interface Suggestion {
   text: string
+  offset: number
+  length: number
   options: {
     text: string
     freq: number