Server Unit Tests

Applied code style to test classes
miniwolf · Dec 1, 2024 · 15a05b2 · 15a05b2
1 parent 14473db
commit 15a05b2
Show file tree

Hide file tree

Showing 16 changed files with 550 additions and 151 deletions.
diff --git a/fagiServer/src/test/java/com/fagi/handler/inputhandler/AddParticipantTests.java b/fagiServer/src/test/java/com/fagi/handler/inputhandler/AddParticipantTests.java
@@ -87,8 +87,7 @@ void whenNewParticipantIsAlreadyInConversation_ShouldResultInUserExistsResponse(
 
     @Test
     void whenNewParticipantUsernameIsNotAnExistingUser_ShouldResultInNoSuchUserResponse() {
-        mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        mockConversationAndRegisterInData(SENDER_USERNAME);
 
         inputHandler.handleInput(addParticipantRequest);
 
@@ -100,8 +99,7 @@ void whenNewParticipantUsernameIsNotAnExistingUser_ShouldResultInNoSuchUserRespo
 
     @Test
     void whenAddingUserToConversation_ShouldResultInNewParticipantBeingInConversationParticipantList() {
-        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -117,8 +115,7 @@ void whenAddingUserToConversation_ShouldResultInNewParticipantBeingInConversatio
 
     @Test
     void whenAddingUserToConversation_ShouldResultInConversationAddedToTheUsersConversationList() {
-        mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -134,8 +131,7 @@ void whenAddingUserToConversation_ShouldResultInConversationAddedToTheUsersConve
 
     @Test
     void whenAddingOnlineUserToConversation_ShouldResultInSendingConversationToThatUser() {
-        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME);
         OutputAgent outputAgent = mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -152,8 +148,7 @@ void whenAddingOnlineUserToConversation_ShouldResultInSendingConversationToThatU
 
     @Test
     void whenAddingUserToConversation_ShouldResultInConversationBeingStored() {
-        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        Conversation conversation = mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -170,8 +165,7 @@ void whenAddingUserToConversation_ShouldResultInConversationBeingStored() {
 
     @Test
     void whenAddingUserToConversation_ShouldResultInNewParticipantBeingStored() {
-        mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -188,8 +182,7 @@ void whenAddingUserToConversation_ShouldResultInNewParticipantBeingStored() {
 
     @Test
     void whenAddingOfflineUserToConversation_ShouldResultInAllIsWellResponse() {
-        mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,
@@ -206,8 +199,7 @@ void whenAddingOfflineUserToConversation_ShouldResultInAllIsWellResponse() {
 
     @Test
     void whenAddingOnlineUserToConversation_ShouldResultInAllIsWellResponse() {
-        mockConversationAndRegisterInData(SENDER_USERNAME
-        );
+        mockConversationAndRegisterInData(SENDER_USERNAME);
         mockOnlineStatusOfUser(
                 data,
                 newParticipant,

diff --git a/fagiServer/src/test/java/com/fagi/handler/inputhandler/CreateConversationTests.java b/fagiServer/src/test/java/com/fagi/handler/inputhandler/CreateConversationTests.java
@@ -46,7 +46,10 @@ void creatingConversationWithNonExistingUser_ShouldResultIn_NoSuchUserResponse()
                 )
                 .addResponse(argumentCaptor.capture());
 
-        Assertions.assertTrue(argumentCaptor.getValue() instanceof NoSuchUser);
+        Assertions.assertInstanceOf(
+                NoSuchUser.class,
+                argumentCaptor.getValue()
+        );
     }
 
     @Test
@@ -93,7 +96,7 @@ void creatingConversation_ShouldResultIn_AddingConversationIdToAllParticipants()
     }
 
     @Test
-    void creatingConversation_ShouldResultIn_StoringParticipants() throws Exception {
+    void creatingConversation_ShouldResultIn_StoringParticipants() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -143,7 +146,7 @@ void creatingConversation_ShouldResultIn_StoringParticipants() throws Exception
                 () -> Assertions.assertEquals(
                         self.getUserName(),
                         storedUsersList
-                                .get(0)
+                                .getFirst()
                                 .getUserName()
                 ),
                 () -> Assertions.assertEquals(
@@ -156,7 +159,7 @@ void creatingConversation_ShouldResultIn_StoringParticipants() throws Exception
     }
 
     @Test
-    void creatingConversation_ShouldNotResultIn_DataRequestedForCurrentUserOuptAgent() throws Exception {
+    void creatingConversation_ShouldNotResultIn_DataRequestedForCurrentUserOuptAgent() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -200,7 +203,7 @@ void creatingConversation_ShouldNotResultIn_DataRequestedForCurrentUserOuptAgent
     }
 
     @Test
-    void creatingConversation_ShouldResultIn_NotifyingOnlineParticipants() throws Exception {
+    void creatingConversation_ShouldResultIn_NotifyingOnlineParticipants() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -283,7 +286,7 @@ void creatingConversation_ShouldResultIn_NotifyingOnlineParticipants() throws Ex
                 ),
                 () -> Assertions.assertEquals(
                         conversation,
-                        conversations.get(0)
+                        conversations.getFirst()
                 ),
                 () -> Assertions.assertEquals(
                         conversation,
@@ -293,7 +296,7 @@ void creatingConversation_ShouldResultIn_NotifyingOnlineParticipants() throws Ex
     }
 
     @Test
-    void creatingConversation_ShouldResultIn_ConversationBeingStored() throws Exception {
+    void creatingConversation_ShouldResultIn_ConversationBeingStored() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -340,7 +343,7 @@ void creatingConversation_ShouldResultIn_ConversationBeingStored() throws Except
     }
 
     @Test
-    void creatingConversation_ShouldResultIn_AllIsWellResponse() throws Exception {
+    void creatingConversation_ShouldResultIn_AllIsWellResponse() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -384,7 +387,7 @@ void creatingConversation_ShouldResultIn_AllIsWellResponse() throws Exception {
     }
 
     @Test
-    void creatingConversation_ShouldResultIn_ConversationResponse() throws Exception {
+    void creatingConversation_ShouldResultIn_ConversationResponse() {
         User self = new User(
                 "Me",
                 "Some password"
@@ -424,6 +427,9 @@ void creatingConversation_ShouldResultIn_ConversationResponse() throws Exception
                 )
                 .addResponse(argumentCaptor.capture());
 
-        Assertions.assertEquals(conversation, argumentCaptor.getValue());
+        Assertions.assertEquals(
+                conversation,
+                argumentCaptor.getValue()
+        );
     }
 }
diff --git a/fagiServer/src/test/java/com/fagi/handler/inputhandler/CreateUserServerTests.java b/fagiServer/src/test/java/com/fagi/handler/inputhandler/CreateUserServerTests.java
@@ -96,13 +96,18 @@ void createUserSucceeds_ShouldDeleteInviteCode() {
 
         var argumentCaptor = ArgumentCaptor.forClass(InviteCodeContainer.class);
         Mockito
-                .verify(data,
-                        times(1))
+                .verify(
+                        data,
+                        times(1)
+                )
                 .storeInviteCodes(argumentCaptor.capture());
 
         Assertions.assertAll(
                 () -> Assertions.assertFalse(inviteCodeContainer.contains(inviteCode)),
-                () -> Assertions.assertEquals(inviteCodeContainer, argumentCaptor.getValue())
+                () -> Assertions.assertEquals(
+                        inviteCodeContainer,
+                        argumentCaptor.getValue()
+                )
         );
     }
 

diff --git a/fagiServer/src/test/java/com/fagi/handler/inputhandler/DeleteFriendRequestTests.java b/fagiServer/src/test/java/com/fagi/handler/inputhandler/DeleteFriendRequestTests.java
@@ -20,8 +20,7 @@
 
 @ExtendWith(MockitoExtension.class)
 public class DeleteFriendRequestTests extends BaseInputHandlerTest {
-    @Mock
-    private User user;
+    @Mock private User user;
 
     void beforeEach() {
     }
@@ -46,8 +45,20 @@ void whenRemovingFriendRequest_ShouldRemoveFromCorrectUser() {
         String otherUsername = "otherUsername";
         inputHandler.handleInput(new DeleteFriendRequest(otherUsername));
 
-        verify(otherUser, never()).removeFriendRequest(eq(data), anyString());
-        verify(user, times(1)).removeFriendRequest(data, otherUsername);
+        verify(
+                otherUser,
+                never()
+        ).removeFriendRequest(
+                eq(data),
+                anyString()
+        );
+        verify(
+                user,
+                times(1)
+        ).removeFriendRequest(
+                data,
+                otherUsername
+        );
     }
 
     @Test
@@ -59,13 +70,19 @@ void whenSuccessfulRemovingFriendRequest_ShouldGetAllIsWellResponse() {
                 .getUser(username);
         doReturn(new AllIsWell())
                 .when(user)
-                .removeFriendRequest(data, otherUsername);
+                .removeFriendRequest(
+                        data,
+                        otherUsername
+                );
         doReturn(username)
                 .when(inputAgent)
                 .getUsername();
 
         inputHandler.handleInput(new DeleteFriendRequest(otherUsername));
 
-        OutputAgentTestUtil.assertOutputAgentReceivedResponseClass(outputAgent, AllIsWell.class);
+        OutputAgentTestUtil.assertOutputAgentReceivedResponseClass(
+                outputAgent,
+                AllIsWell.class
+        );
     }
 }
diff --git a/fagiServer/src/test/java/com/fagi/handler/inputhandler/DeleteFriendTests.java b/fagiServer/src/test/java/com/fagi/handler/inputhandler/DeleteFriendTests.java
@@ -45,8 +45,20 @@ void whenRemovingFriend_ShouldRemoveFromCorrectUser() {
         String otherUsername = "otherUsername";
         inputHandler.handleInput(new DeleteFriend(otherUsername));
 
-        verify(otherUser, never()).removeFriend(eq(data), anyString());
-        verify(user, times(1)).removeFriend(data, otherUsername);
+        verify(
+                otherUser,
+                never()
+        ).removeFriend(
+                eq(data),
+                anyString()
+        );
+        verify(
+                user,
+                times(1)
+        ).removeFriend(
+                data,
+                otherUsername
+        );
     }
 
     @Test
@@ -58,13 +70,19 @@ void whenSuccessfulRemovingFriend_ShouldGetAllIsWellResponse() {
                 .getUser(username);
         doReturn(new AllIsWell())
                 .when(user)
-                .removeFriend(data, otherUsername);
+                .removeFriend(
+                        data,
+                        otherUsername
+                );
         doReturn(username)
                 .when(inputAgent)
                 .getUsername();
 
         inputHandler.handleInput(new DeleteFriend(otherUsername));
 
-        OutputAgentTestUtil.assertOutputAgentReceivedResponseClass(outputAgent, AllIsWell.class);
+        OutputAgentTestUtil.assertOutputAgentReceivedResponseClass(
+                outputAgent,
+                AllIsWell.class
+        );
     }
 }