Upgrade gradle java kotlin fix tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested that RemoveParticipantRequests are handled as expected
* Upgraded java to 21 * Upgraded gradle to 8.8 * Upgraded test frameworks for server * Upgraded javafxplugin * Upgraded javafx to 21 * Reintroduced InviteCode class as pure integers introduced unexpected behaviour in java lists. Now invite codes accepts strings as well. * Fixed tests * Fixed tests - Use push instead of press as push also releases key * Fixed tests - Mockito no longer supports spy on mocks * Fixed tests - Mockito times only records calls with objects that is of type used in ArgumentCaptor * Fixed tests - StyleableMatchers.doesntContainsClass no longer exists so created our own matcher called HasStyleClassMatcher
* Rewritten all groovy gradle files to kotlin * Test reporting rewritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a general upgrade of gradle, java, our libraries and fixed the tests that failed as a consequence. I have also changed our gradle to kotlin as that is much better.