Skip to content

Commit

Permalink
remove now superfluous mirage-crypto-rng-{lwt,eio,async} (#256)
Browse files Browse the repository at this point in the history
* remove now superfluous mirage-crypto-rng-{lwt,eio,async}

we have Mirage_crypto_rng_unix.use_default () now, and by default use getrandom

* remove these packages from CI

* fix enabled_if condition
  • Loading branch information
hannesm authored Feb 5, 2025
1 parent fe7bad7 commit 0a7e572
Show file tree
Hide file tree
Showing 20 changed files with 13 additions and 543 deletions.
4 changes: 2 additions & 2 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ freebsd_task:
- opam env

pin_packages_script:
- opam install -y --deps-only -t ./mirage-crypto.opam ./mirage-crypto-rng.opam ./mirage-crypto-rng-lwt.opam ./mirage-crypto-rng-mirage.opam ./mirage-crypto-ec.opam ./mirage-crypto-pk.opam
- opam install -y --deps-only -t ./mirage-crypto.opam ./mirage-crypto-rng.opam ./mirage-crypto-rng-mirage.opam ./mirage-crypto-ec.opam ./mirage-crypto-pk.opam

test_script: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec
test_script: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec

test_mirage_script: eval `opam env` && ./.test-mirage.sh
14 changes: 6 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,17 @@ jobs:
with:
opam-local-packages: |
*.opam
!mirage-crypto-rng-eio.opam
!mirage-crypto-rng-miou-unix.opam
ocaml-compiler: ${{ matrix.ocaml-version }}

- name: Install dependencies
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-lwt mirage-crypto-rng-mirage mirage-crypto-pk mirage-crypto-ec mirage-crypto-rng-async
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-mirage mirage-crypto-pk mirage-crypto-ec

- name: Build
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec,mirage-crypto-rng-async
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec

- name: Test
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec,mirage-crypto-rng-async
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec

build-test-ocaml-5:
name : Tests with OCaml 5
Expand All @@ -57,15 +56,14 @@ jobs:
opam-local-packages: |
mirage-crypto.opam
mirage-crypto-rng.opam
mirage-crypto-rng-eio.opam
mirage-crypto-rng-miou-unix.opam
ocaml-compiler: ${{ matrix.ocaml-version }}

- name: Install dependencies
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-eio mirage-crypto-rng-miou-unix
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-miou-unix

- name: Build
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-eio,mirage-crypto-rng-miou-unix
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-miou-unix

- name: Test
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-eio,mirage-crypto-rng-miou-unix
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-miou-unix
8 changes: 3 additions & 5 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,14 @@ jobs:
default: https://github.com/ocaml/opam-repository.git
opam-local-packages: |
*.opam
!mirage-crypto-rng-async.opam
!mirage-crypto-rng-eio.opam
!mirage-crypto-rng-miou-unix.opam
ocaml-compiler: ${{ matrix.ocaml-version }}

- name: Install dependencies
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-lwt mirage-crypto-rng-mirage mirage-crypto-pk mirage-crypto-ec
run: opam install --deps-only -t mirage-crypto mirage-crypto-rng mirage-crypto-rng-mirage mirage-crypto-pk mirage-crypto-ec

- name: Build
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec
run: opam exec -- dune build -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec

- name: Test
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec
run: opam exec -- dune runtest -p mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec
2 changes: 1 addition & 1 deletion ci/build-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ opamrun update
# Build logic
# 2024-02-09: Remove mirage-crypto-pk on Windows since no portable GMP library (used by Zarith).
# 2024-02-24: Remove mirage-crypto-ec on Windows since it results in test failures.
packages_TOPOLOGICALSORT="mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-lwt,mirage-crypto-rng-mirage"
packages_TOPOLOGICALSORT="mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage"
case "$dkml_host_abi" in
windows_*)
packages_TOPOLOGICALSORT="$packages_TOPOLOGICALSORT"
Expand Down
31 changes: 0 additions & 31 deletions mirage-crypto-rng-async.opam

This file was deleted.

31 changes: 0 additions & 31 deletions mirage-crypto-rng-eio.opam

This file was deleted.

27 changes: 0 additions & 27 deletions mirage-crypto-rng-lwt.opam

This file was deleted.

5 changes: 0 additions & 5 deletions rng/async/dune

This file was deleted.

84 changes: 0 additions & 84 deletions rng/async/mirage_crypto_rng_async.ml

This file was deleted.

19 changes: 0 additions & 19 deletions rng/async/mirage_crypto_rng_async.mli

This file was deleted.

4 changes: 0 additions & 4 deletions rng/eio/dune

This file was deleted.

87 changes: 0 additions & 87 deletions rng/eio/mirage_crypto_rng_eio.ml

This file was deleted.

Loading

0 comments on commit 0a7e572

Please sign in to comment.