Skip to content

Commit f86c86f

Browse files
committed
v1.4.35
bugfix
1 parent 1ae204a commit f86c86f

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,4 @@
2323
- v1.4.1: FoundryVTT v12 compatibility
2424
- v1.4.20: Restore legacy sheet compatibility, add new tidy sheet compatibility
2525
- v1.4.30: fix bug with hidden skills and abilities when switching to edit mode in dndv3 sheet
26+
- v1.4.35: fix bug with hidden saves. Fix missing reload confirm.

css/dnd5e-custom-skills.css

+1
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ form .form-group.hide-skills input {
140140
.sheet.actor .ability-scores .ability.disabled,
141141
/** dnd v3 **/
142142
.sheet.actor.character .ability-scores .ability-score.disabled,
143+
.dnd5e2.sheet.actor.character .sheet-body .saves>ul>li.disabled,
143144
.sheet.actor.character ul.skills-list li.skill.disabled,
144145
/** dnd v3 **/
145146
.sheet.actor.character .sheet-body .skills>ul>li.disabled,

dnd5e-custom-skills.js

+7-17
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ class CustomSkillsForm extends FormApplication {
4242
id: 'skills-form',
4343
template: `modules/${MODULE_NAME}/templates/skills-config.html`,
4444
width: 700,
45-
closeOnSubmit: false
45+
closeOnSubmit: false,
46+
requiresReload: true
4647
});
4748
}
4849

@@ -60,6 +61,8 @@ class CustomSkillsForm extends FormApplication {
6061
return data;
6162
}
6263

64+
65+
6366
onReset() {
6467
this.reset = true;
6568
game.settings.set(MODULE_NAME, 'settings', {});
@@ -115,6 +118,8 @@ class CustomSkillsForm extends FormApplication {
115118

116119
await CustomSkills.updateActors(newSkills, newAbilities);
117120

121+
SettingsConfig.reloadConfirm({ world: true });
122+
118123
return this.render();
119124
}
120125

@@ -800,25 +805,10 @@ class CustomSkills {
800805
abbrKey = this.getI18nKey(a);
801806
if (customAbilities[a].applied) {
802807
systemAbilities[a] = this.getBaseAbility(customAbilities[a].applied, customAbilities[a].label);
803-
// systemAbilityAbbr[a] = label.slice(0, 3).toLowerCase();
804-
/*if (isFallback) {
805-
game.i18n._fallback.DND5E[abbrKey] = systemAbilityAbbr[a];
806-
} else {
807-
game.i18n.translations.DND5E[abbrKey] = systemAbilityAbbr[a];
808-
}*/
809808
if (window._isDaeActive) {
810809
this.daeAutoFields(a);
811810
}
812811
} else {
813-
// not applied, we should remove it.
814-
/*if (typeof systemAbilities[a] != "undefined") {
815-
systemAbilities = this.removeKey(systemAbilities, a);
816-
}
817-
if (typeof systemAbilityAbbr[a] != "undefined") {
818-
systemAbilityAbbr = this.removeKey(systemAbilityAbbr, a);
819-
}
820-
*/
821-
822812
// remove translation
823813
if (isFallback) {
824814
if (typeof game?.i18n?._fallback?.DND5E != 'undefined' && typeof game?.i18n?._fallback?.DND5E[abbrKey] != 'undefined') {
@@ -868,7 +858,6 @@ class CustomSkills {
868858
// clean leftovers on players actors
869859
await CustomSkills.cleanActors();
870860
ui.notifications.info(game.i18n.localize(MODULE_NAME + '.updateDone'));
871-
872861
return true;
873862
}
874863

@@ -1064,6 +1053,7 @@ function addLabels(app, html, data) {
10641053
if (hiddenAbilities[ha]) {
10651054
if (sheetVersion == 'dnd2') {
10661055
$('.ability-scores .ability-score[data-ability ="' + ha + '"]', current_sheet).addClass('disabled');
1056+
$('.saves li[data-ability ="' + ha + '"]', current_sheet).addClass('disabled');
10671057
} else if (sheetVersion == 'legacy') {
10681058
$('.ability-scores .ability[data-ability ="' + ha + '"]', current_sheet).addClass('disabled');
10691059
} else if (sheetVersion == 'tidy') {

module.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
"id": "dnd5e-custom-skills",
33
"title": "5e - Custom Abilities & Skills",
44
"description": "FoundryVTT module for adding new character skills and abilities",
5-
"version": "1.4.30",
5+
"version": "1.4.35",
66
"compatibility": {
77
"minimum": "12",
8-
"verified": "12.324"
8+
"verified": "12.330"
99
},
1010
"relationships": {
1111
"systems": [
@@ -15,7 +15,7 @@
1515
"manifest": "https://raw.githubusercontent.com/foundryvtt/dnd5e/master/system.json",
1616
"compatibility": {
1717
"minimum": "3",
18-
"verified": "3.2.0"
18+
"verified": "3.3.1"
1919
}
2020
}
2121
]

0 commit comments

Comments
 (0)