You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not using jiff for my own uses and having minijinja-contrib use time and time-tz is an extra dep. I also expect that in general jiff is going to win out so I need some sort of strategy to move over.
The main blocker is that the format in which time formats strings is incompatible with jiff. The format that the time crate accepts is [hour]:[minute]:[second] instead of %H:%M:%S.
The most trivial option would be different feature flags, another option would be to implement the format strings from the time crate for jiff. Unclear is also what the future of string formatting in jiff is. For instance this PR already changes some behavior: BurntSushi/jiff#147 and locale support is not really planned: BurntSushi/jiff#4
The text was updated successfully, but these errors were encountered:
Unclear is also what the future of string formatting in jiff is.
I don't have any immediate plans to expand it substantially. The idea with the strtime API is to match the prevailing convention. (And the change I made was toward that end. Hopefully I don't need to change anything else.) I think it's unlikely that Jiff will get support for time's bespoke formatting DSL. What is the issue with migrating? Is time's DSL exposed in your API? (It looks like it isn't.)
As for locale support, what are you doing now? I don't think time has locale support. My plan here is to push folks toward using icu (with routines for doing the necessary datetime conversions), because locale support is a huge can of worms that I think is better for the icu folks to own.
For instance this PR already changes some behavior
To respond to what I think is the implied question of "how much churn can I expect," I'll say that a jiff 0.2 release is imminent. And unless anything severe comes up, my plan is to release jiff 1.0 this summer and then commit to it indefinitely.
Oh I see, the labels short and medium and what not are just convenience things. But you do actually expose the full time DSL. Yeah, that's a tough one. Owch.
It was a mistake to expose the time crate like that for sure. Maybe the first step would be to just parse down strftime in the contrib crate and map it to the format string from time, and deprecate the other one.
I am not using jiff for my own uses and having minijinja-contrib use
time
andtime-tz
is an extra dep. I also expect that in general jiff is going to win out so I need some sort of strategy to move over.The main blocker is that the format in which
time
formats strings is incompatible with jiff. The format that the time crate accepts is[hour]:[minute]:[second]
instead of%H:%M:%S
.The most trivial option would be different feature flags, another option would be to implement the format strings from the time crate for jiff. Unclear is also what the future of string formatting in jiff is. For instance this PR already changes some behavior: BurntSushi/jiff#147 and locale support is not really planned: BurntSushi/jiff#4
The text was updated successfully, but these errors were encountered: