S4MK3: add support for screens #703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ywwg I would really appreciate a review if you can! :) |
3 tasks
ronso0
reviewed
Dec 8, 2024
|
|
||
| By default, the screens are standalone, meaning they do not interact with the device states. This means that local state such as deck selection or shifting will not trigger any screen interaction, and thus you should expect only Deck A and B to be displayed on these screen by default, although this can be changed in the controller settings. | ||
|
|
||
| .. note:: it exists an API that was temporary parked that allows mappings to communicate. If you want, you may build a version of Mixxx with feature and you should be able to enable the feature in the controller settings. |
There was a problem hiding this comment.
Let's add a link to the branch/PR.
If someone is willing to try this it should be as easy as possible IMO.
There was a problem hiding this comment.
I have added the link directly there now
ronso0
reviewed
Dec 8, 2024
| @@ -133,21 +144,26 @@ Moves modes define how the "move" encoder (the one on the left) reacts when used | |||
| 2. **Grid**: The track's detected beats will be move forward or backward on the waveform. | |||
| 3. **BPM**: The track's detected BPM will be increased or decreased. | |||
| 4. **Keyboard**: The keyboard's keys displayed on pads get moved up or down to display higher or lower keynotes. | |||
| 5. **Hotcue color**: When selecting a hotcue, the move encoder can be used to change the selected color. | |||
There was a problem hiding this comment.
While the hotcue button is pressed?
There was a problem hiding this comment.
IMO it would be better to explain the modes first then refer to them in each component section.
There was a problem hiding this comment.
Are you suggesting to swap the list and table
ronso0
reviewed
Dec 8, 2024
| @@ -384,9 +423,9 @@ Mapping options | |||
|
|
|||
| There are various option that can be used to change some behavior: | |||
|
|
|||
| ============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ================================================================================================================================================================================================================ | |||
| ============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ====================================================================================================================================================================================================================================== | |||
| Setting Variable value Default Range Description | |||
There was a problem hiding this comment.
My experience with this table:
- the content is very wide and I have to scroll horizontally to check the description for example
- I don't need the
Variable valuecolumn. If I'd be interested, I'd look at the settings in the js file
-> this would reduce the table width - in the
Defaultcolumn we may remove the the prefix (LEDColors etc.) and just show the values
-> this would reduce the table width
There was a problem hiding this comment.
Since 2.4 is EOL, I'm tempted to remove a lot actually, since with the SettingsAPI, you shouldn't have to edit the file, except if you are hacking around. Wdyt?
|
Wanted to take look but Netlify fails with |
acolombier
force-pushed
the
feat/s4-mk3-screens
branch
from
0a13166 to
4551cbc
Compare
|
Fixed @ronso0 - my branch was quite out of date it turns out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to mixxxdj/mixxx#13653
https://deploy-preview-703--mixxx-manual.netlify.app/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.html