Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding Mixxx PR is here:
mixxxdj/mixxx#14502
This also has a commit removing an accidental unnecessary line in the M-Vave SMC-Mixer page. That can be cherry picked over to 2.5 or we can just wait until this PR is merged.
We should also decide how we're going to handle keyboards that are mapped differently (you can change the way the buttons work and whether they send midi, MMC, and what midi channels and numbers they use, etc. on the keyboard itself). Ie. do we make it configurable what mapped Midi value goes to what action in Mixxx, or publish in the manual what values and button types we expect and let the user reconfigure their keyboard?
Deploy preview: https://deploy-preview-744--mixxx-manual.netlify.app/hardware/controllers/arturia_keylab_mk1.html