Eric/uikit scroll to section #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
Replaces the SwiftUI-based index scrolling with a UIKit/introspection-based implementation that uses
UICollectionView.scrollToto perform scrolling.Since we already have a custom scroll-to-top implementation on this view anyway, I also use the UIKit approach to handle that and have ripped out the
ScrollViewReaderaltogether.Implementation Notes
Setting the scroll target to
.topputs it a little too at the top (and trying to fix it with edge insets on theUICollectionViewmakes the top insets bad), I've set the scroll target to.verticallyCentered.